Re: [PATCH v3 1/7] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible

Clément Péron
2019-05-26T18:47:35Z

Hi Maxime,

On Sun, 26 May 2019 at 20:22, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Sat, May 25, 2019 at 06:23:17PM +0200, Clément Péron wrote:
> > Allwinner H6 has a SPDIF controller with an increase of the fifo
> > size and a sligher difference in memory mapping compare to H3/A64.
> >
> > This make it not compatible with the previous generation.
> >
> > Introduce a specific bindings for H6 SoC.
> >
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > ---
> > Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt b/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt
> > index 0c64a209c2e9..c0fbb50a4df9 100644
> > --- a/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt
> > +++ b/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt
> > @@ -7,10 +7,11 @@ For now only playback is supported.
> >
> > Required properties:
> >
> > - - compatible : should be one of the following:
> > + - compatible : Should be one of the following:
> > - "allwinner,sun4i-a10-spdif": for the Allwinner A10 SoC
> > - "allwinner,sun6i-a31-spdif": for the Allwinner A31 SoC
> > - "allwinner,sun8i-h3-spdif": for the Allwinner H3 SoC
> > + - "allwinner,sun50i-h6-spdif": for the allwinner H6 SoC
>
> This won't apply anymore on top of next, we've moved to a YAML
> schemas.

Indeed I have based this series on sunxi instead of sound.
Thanks for pointing out that.
Clément

>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com