From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
lgirdwood@gmail.com,
Richard Fitzgerald <rf@opensource.cirrus.com>,
robh+dt@kernel.org, lee.jones@linaro.org
Subject: Re: [PATCH 2/5] ASoC: madera: Add common support for Cirrus Logic Madera codecs
Date: Mon, 27 May 2019 09:32:38 +0100 [thread overview]
Message-ID: <20190527083238.GD28362@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20190526121846.GG2456@sirena.org.uk>
On Sun, May 26, 2019 at 01:18:46PM +0100, Mark Brown wrote:
> On Fri, May 24, 2019 at 04:24:10PM +0100, Richard Fitzgerald wrote:
> > On 24/05/19 16:21, Richard Fitzgerald wrote:
> > > On 24/05/19 15:56, Mark Brown wrote:
> > > > This will delay both before and after every power up and power down.
> > > > Are you sure that makes sense?
>
> > > I think that's correct but we can re-check with hardware people.
> > > It's not just a delay, it needs to ensure there are always a
> > > certain number of SYSCLK cycles in the hardware to avoid leaving
> > > certain state machines in limbo.
>
> That sounds like you might want both _POST_PMU and _POST_PMD but do you
> really need the _PREs as well?
Yeah the requirement from the hardware guys was that we needed a
guard band between changing the SYSCLK state and other things
happening. So it has to happen both before and after the state of
SYSCLK changes. It is certainly far from ideal but it is what it
is.
Thanks,
Charles
next prev parent reply other threads:[~2019-05-27 8:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 10:41 [PATCH 1/5] ASoC: madera: Add DT bindings for Cirrus Logic Madera codecs Charles Keepax
2019-05-24 10:41 ` [PATCH 2/5] ASoC: madera: Add common support " Charles Keepax
2019-05-24 14:56 ` Mark Brown
2019-05-24 15:21 ` Richard Fitzgerald
2019-05-24 15:24 ` Richard Fitzgerald
2019-05-26 12:18 ` Mark Brown
2019-05-27 8:32 ` Charles Keepax [this message]
2019-05-24 15:33 ` Charles Keepax
2019-05-24 10:41 ` [PATCH 3/5] ASoC: cs47l35: Add codec driver for Cirrus Logic CS47L35 Charles Keepax
2019-05-24 10:41 ` [PATCH 4/5] ASoC: cs47l85: Add codec driver for Cirrus Logic CS47L85 Charles Keepax
2019-05-24 10:41 ` [PATCH 5/5] ASoC: cs47l90: Add codec driver for Cirrus Logic CS47L90 Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527083238.GD28362@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=mark.rutland@arm.com \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).