[PATCH] dt-bindings: phy: mvebu-comphy: Update references to CP110 nodes

[PATCH] dt-bindings: phy: mvebu-comphy: Update references to CP110 nodes

[Miquel Raynal]

From: Grzegorz Jaszczyk <jaz@semihalf.com>

The CP110 DT nodes references have changed, reflect these changes in
COMPHY documentation.

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 .../devicetree/bindings/phy/phy-mvebu-comphy.txt          | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
index cf2cd86db267..af2402c18513 100644
--- a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
+++ b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
@@ -35,19 +35,19 @@ Required properties (child nodes):
 
 Examples:
 
-	cpm_comphy: phy@120000 {
+	CP110_LABEL(comphy): phy@120000 {
 		compatible = "marvell,comphy-cp110";
 		reg = <0x120000 0x6000>;
-		marvell,system-controller = <&cpm_syscon0>;
+		marvell,system-controller = <&CP110_LABEL(syscon0)>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		cpm_comphy0: phy@0 {
+		CP110_LABEL(comphy0): phy@0 {
 			reg = <0>;
 			#phy-cells = <1>;
 		};
 
-		cpm_comphy1: phy@1 {
+		CP110_LABEL(comphy1): phy@1 {
 			reg = <1>;
 			#phy-cells = <1>;
 		};
-- 
2.19.1

Re: [PATCH] dt-bindings: phy: mvebu-comphy: Update references to CP110 nodes

[Rob Herring]

On Tue, May 21, 2019 at 9:35 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> From: Grzegorz Jaszczyk <jaz@semihalf.com>
>
> The CP110 DT nodes references have changed, reflect these changes in
> COMPHY documentation.

This change isn't necessary. The examples are just examples. They
don't have to match anything exactly.

>
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  .../devicetree/bindings/phy/phy-mvebu-comphy.txt          | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> index cf2cd86db267..af2402c18513 100644
> --- a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> @@ -35,19 +35,19 @@ Required properties (child nodes):
>
>  Examples:
>
> -       cpm_comphy: phy@120000 {
> +       CP110_LABEL(comphy): phy@120000 {

Also, as we convert bindings to schema, the examples are compiled and
this won't without CP110_LABEL defined.

>                 compatible = "marvell,comphy-cp110";
>                 reg = <0x120000 0x6000>;
> -               marvell,system-controller = <&cpm_syscon0>;
> +               marvell,system-controller = <&CP110_LABEL(syscon0)>;
>                 #address-cells = <1>;
>                 #size-cells = <0>;
>
> -               cpm_comphy0: phy@0 {
> +               CP110_LABEL(comphy0): phy@0 {
>                         reg = <0>;
>                         #phy-cells = <1>;
>                 };
>
> -               cpm_comphy1: phy@1 {
> +               CP110_LABEL(comphy1): phy@1 {
>                         reg = <1>;
>                         #phy-cells = <1>;
>                 };
> --
> 2.19.1
>

Re: [PATCH] dt-bindings: phy: mvebu-comphy: Update references to CP110 nodes

[Miquel Raynal]

Hi Rob,

Rob Herring <robh+dt@kernel.org> wrote on Wed, 22 May 2019 08:15:27
-0500:

> On Tue, May 21, 2019 at 9:35 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > From: Grzegorz Jaszczyk <jaz@semihalf.com>
> >
> > The CP110 DT nodes references have changed, reflect these changes in
> > COMPHY documentation.  
> 
> This change isn't necessary. The examples are just examples. They
> don't have to match anything exactly.

Ok then, let's drop it.

> 
> >
> > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >  .../devicetree/bindings/phy/phy-mvebu-comphy.txt          | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> > index cf2cd86db267..af2402c18513 100644
> > --- a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> > +++ b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> > @@ -35,19 +35,19 @@ Required properties (child nodes):
> >
> >  Examples:
> >
> > -       cpm_comphy: phy@120000 {
> > +       CP110_LABEL(comphy): phy@120000 {  
> 
> Also, as we convert bindings to schema, the examples are compiled and
> this won't without CP110_LABEL defined.

I didn't thought about the YAML schema conversion issue (IIRC there are
already occurrences of such macro in the bindings).

Thanks,
Miquèl