From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH] ARM: dts: rockchip: Add pin names for rk3288-veyron jaq, mickey, speedy Date: Tue, 28 May 2019 13:29:47 -0700 Message-ID: <20190528202947.GL40515@google.com> References: <20190524233309.45420-1-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190524233309.45420-1-dianders@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Douglas Anderson Cc: Heiko Stuebner , briannorris@chromium.org, ryandcase@chromium.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Fri, May 24, 2019 at 04:33:09PM -0700, Douglas Anderson wrote: > This is like commit 0ca87bd5baa6 ("ARM: dts: rockchip: Add pin names > for rk3288-veyron-jerry") and commit ca3516b32cd9 ("ARM: dts: > rockchip: Add pin names for rk3288-veyron-minnie") but for 3 more > veyron boards. > > A few notes: > - While there is most certainly duplication between all the veyron > boards, it still feels like it is sane to just have each board have > a full list of its pin names. The format of "gpio-line-names" does > not lend itself to one-off overriding and besides it seems sane to > more fully match schematic names. Also note that the extra > duplication here is only in source code and is unlikely to ever > change (since these boards are shipped). Duplication in the .dtb > files is unavoidable. > - veyron-jaq and veyron-mighty are very closely related and so I have > shared a single list for them both with comments on how they are > different. This is just a typo fix on one of the boards, a possible > missing signal on one of the boards (or perhaps I was never given > the most recent schematics?) and dealing with the fact that one of > the two boards has full sized SD. > > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke