From: kbuild test robot <lkp@intel.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>,
devicetree@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Miroslav Lichvar <mlichvar@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH V4 net-next 6/6] ptp: Add a driver for InES time stamping IP core.
Date: Sat, 1 Jun 2019 00:03:50 +0800 [thread overview]
Message-ID: <201906010042.seCKm5hR%lkp@intel.com> (raw)
In-Reply-To: <b721edfadbfa8782513ed8441a681af61f3fa59e.1559109077.git.richardcochran@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2021 bytes --]
Hi Richard,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Richard-Cochran/Peer-to-Peer-One-Step-time-stamping/20190531-213601
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers//ptp/ptp_ines.c: In function 'ines_txtstamp':
>> drivers//ptp/ptp_ines.c:674:3: warning: 'old_skb' may be used uninitialized in this function [-Wmaybe-uninitialized]
kfree_skb(old_skb);
^~~~~~~~~~~~~~~~~~
vim +/old_skb +674 drivers//ptp/ptp_ines.c
651
652 static void ines_txtstamp(struct mii_timestamper *mii_ts,
653 struct sk_buff *skb, int type)
654 {
655 struct ines_port *port = container_of(mii_ts, struct ines_port, mii_ts);
656 struct sk_buff *old_skb;
657 unsigned long flags;
658
659 if (!port->txts_enabled || ines_txts_onestep(port, skb, type)) {
660 kfree_skb(skb);
661 return;
662 }
663
664 spin_lock_irqsave(&port->lock, flags);
665
666 if (port->tx_skb)
667 old_skb = port->tx_skb;
668
669 port->tx_skb = skb;
670
671 spin_unlock_irqrestore(&port->lock, flags);
672
673 if (old_skb)
> 674 kfree_skb(old_skb);
675
676 schedule_delayed_work(&port->ts_work, 1);
677 }
678
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50626 bytes --]
next prev parent reply other threads:[~2019-05-31 16:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 5:58 [PATCH V4 net-next 0/6] Peer to Peer One-Step time stamping Richard Cochran
2019-05-29 5:58 ` [PATCH V4 net-next 1/6] net: Introduce peer to peer one step PTP " Richard Cochran
2019-05-29 5:58 ` [PATCH V4 net-next 2/6] net: Introduce a new MII time stamping interface Richard Cochran
2019-05-31 15:05 ` kbuild test robot
2019-05-31 17:08 ` kbuild test robot
2019-05-31 18:23 ` kbuild test robot
2019-05-29 5:58 ` [PATCH V4 net-next 3/6] net: Add a layer for non-PHY MII time stamping drivers Richard Cochran
2019-05-29 5:58 ` [PATCH V4 net-next 4/6] dt-bindings: ptp: Introduce MII time stamping devices Richard Cochran
2019-05-29 5:58 ` [PATCH V4 net-next 5/6] net: mdio: of: Register discovered MII time stampers Richard Cochran
2019-05-29 5:58 ` [PATCH V4 net-next 6/6] ptp: Add a driver for InES time stamping IP core Richard Cochran
2019-05-31 16:03 ` kbuild test robot [this message]
2019-05-30 18:55 ` [PATCH V4 net-next 0/6] Peer to Peer One-Step time stamping David Miller
2019-05-30 19:58 ` David Miller
2019-05-31 5:51 ` Richard Cochran
2019-05-31 17:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201906010042.seCKm5hR%lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=kbuild-all@01.org \
--cc=mark.rutland@arm.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).