From: Stephen Boyd <sboyd@kernel.org>
To: Fabio Estevam <festevam@gmail.com>,
Leonard Crestez <leonard.crestez@nxp.com>
Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
Anson Huang <anson.huang@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] clk: imx8qxp: Use devm_platform_ioremap_resource()
Date: Thu, 06 Jun 2019 10:22:09 -0700 [thread overview]
Message-ID: <20190606172210.7B3F82083E@mail.kernel.org> (raw)
In-Reply-To: <VI1PR04MB5055C4B288BC19F6E1EF9D65EE170@VI1PR04MB5055.eurprd04.prod.outlook.com>
Quoting Leonard Crestez (2019-06-06 10:15:32)
> On 06.06.2019 19:55, Stephen Boyd wrote:
> > Quoting Fabio Estevam (2019-06-06 09:44:43)
> >> Use devm_platform_ioremap_resource() to simplify the code a bit.
> >>
> >> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> >> ---
> >
> > Reviewed-by: Stephen Boyd <sboyd@kernel.org>
>
> An extremely similar patch was already submitted and then reverted
> because it breaks boot:
>
> https://patchwork.kernel.org/patch/10908807/
>
> I tested and this new patch also breaks boot.
>
> The current imx8 lpcg driver maps entire subsystems at once and if
> devm_platform_ioremap_resource is used then devices inside the subsystem
> will fail to probe, including lpuart!
>
> The hardware on imx8qxp and related parts (imx8qm) has multiple separate
> LPCG blocks interspersed between devices. Some refactoring patches were
> posted by Aisheng to split LPCG into multiple blocks but apparently got
> stuck in review:
>
> https://patchwork.kernel.org/cover/10924029/
> https://patchwork.kernel.org/cover/10824443/
> https://patchwork.kernel.org/cover/10824537/
>
> There were some disagreements regarding DT bindings for split imx8
> clocks, what would it take to move those patches forward?
>
Don't know. I'll have to read those patches on the list and reply there.
next prev parent reply other threads:[~2019-06-06 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190606164443.6991-1-festevam@gmail.com>
[not found] ` <20190606165546.6675520693@mail.kernel.org>
2019-06-06 17:15 ` [PATCH] clk: imx8qxp: Use devm_platform_ioremap_resource() Leonard Crestez
2019-06-06 17:22 ` Stephen Boyd [this message]
2019-06-06 17:55 ` Leonard Crestez
2019-06-06 17:57 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606172210.7B3F82083E@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox