From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 1/3] Documentation: dt-bindings: add the Amlogic Meson Temperature Sensor Date: Sat, 8 Jun 2019 14:08:37 +0100 Message-ID: <20190608140837.34a499a4@archlinux> References: <20190604144714.2009-1-glaroque@baylibre.com> <20190604144714.2009-2-glaroque@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190604144714.2009-2-glaroque@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org To: Guillaume La Roque Cc: khilman@baylibre.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue, 4 Jun 2019 16:47:12 +0200 Guillaume La Roque wrote: > This adds the devicetree binding documentation for the Temperature > Sensor found in the Amlogic Meson G12 SoCs. > Currently only the G12A SoCs are supported. > > Signed-off-by: Guillaume La Roque Hi Guillaume, I'm afraid we decided a month or so back that all new dt bindings proposed for IIO drivers should be in yaml format. Please reformat this appropriately for v2 and make sure to run make dt_bindings_check. There are a few examples in tree already, but we are deliberately not converting existing bindings too quickly to avoid overloading reviewers. Thanks, Jonathan > --- > .../iio/temperature/amlogic,meson-tsensor.txt | 31 +++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/temperature/amlogic,meson-tsensor.txt > > diff --git a/Documentation/devicetree/bindings/iio/temperature/amlogic,meson-tsensor.txt b/Documentation/devicetree/bindings/iio/temperature/amlogic,meson-tsensor.txt > new file mode 100644 > index 000000000000..d064db0e9cac > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/temperature/amlogic,meson-tsensor.txt > @@ -0,0 +1,31 @@ > +* Amlogic Meson Temperature Sensor > + > +Required properties: > +- compatible: depending on the SoC and the position of the sensor, > + this should be one of: > + - "amlogic,meson-g12a-cpu-tsensor" for the CPU G12A SoC sensor > + - "amlogic,meson-g12a-ddr-tsensor" for the DDR G12A SoC sensor > + followed by the common : > + - "amlogic,meson-g12a-tsensor" for G12A SoC family > +- reg: the physical base address and length of the registers > +- interrupts: the interrupt indicating end of sampling > +- clocks: phandle identifier for the reference clock of temperature sensor > +- #io-channel-cells: must be 1, see ../iio-bindings.txt > +- amlogic,ao-secure: phandle to the ao-secure syscon > + > +Optional properties: > +- amlogic,critical-temperature: temperature value in milli degrees Celsius > + to set automatic reboot on too high temperature > + > +Example: > + cpu_temp: temperature-sensor@ff634800 { > + compatible = "amlogic,meson-g12a-cpu-tsensor", > + "amlogic,meson-g12a-tsensor"; > + reg = <0x0 0xff634800 0x0 0x50>; > + interrupts = ; > + clocks = <&clkc CLKID_TS>; > + status = "okay"; > + #io-channel-cells = <1>; > + amlogic,meson-ao-secure = <&sec_AO>; > + amlogic,critical-temperature = <115000>; > + };