From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190608091537.GG9160@vkoul-mobl.Dlink> References: <20190607101234.30449-1-vkoul@kernel.org> <20190607101234.30449-2-vkoul@kernel.org> <20190607174353.31EDA208C3@mail.kernel.org> <20190608091537.GG9160@vkoul-mobl.Dlink> From: Stephen Boyd Subject: Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for SM8150 Date: Mon, 10 Jun 2019 08:08:26 -0700 Message-Id: <20190610150827.607F6207E0@mail.kernel.org> To: Vinod Koul Cc: Rob Herring , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Deepak Katragadda , Andy Gross , David Brown , Michael Turquette , Mark Rutland , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Taniya Das List-ID: Quoting Vinod Koul (2019-06-08 02:15:37) > On 07-06-19, 10:43, Stephen Boyd wrote: > > Quoting Vinod Koul (2019-06-07 03:12:34) > > > diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8= 150.c > > > new file mode 100644 > > > index 000000000000..1cbc884444c9 > > > --- /dev/null > > > +++ b/drivers/clk/qcom/gcc-sm8150.c > > > +static const struct parent_map gcc_parent_map_0[] =3D { > > > + { P_BI_TCXO, 0 }, > > > + { P_GPLL0_OUT_MAIN, 1 }, > > > + { P_GPLL0_OUT_EVEN, 6 }, > > > + { P_CORE_BI_PLL_TEST_SE, 7 }, > > > +}; > > > + > > > +static const char * const gcc_parent_names_0[] =3D { > >=20 > > We have a new way of specifying clk parents now. Can you use that > > instead of using strings everywhere? >=20 > Okay I will update, any pointers on new implementation I can look up? >=20 Not really yet. Chen-Yu is working on the Allwinner driver (drivers/clk/sunxi-ng/) and some work from Jeff for MSM8998 is on the list that you can look at.