* [PATCH] ARM: dts: Drop bogus CLKSEL for timer12 on dra7
@ 2019-05-30 6:56 Tony Lindgren
2019-05-31 12:05 ` Tomi Valkeinen
2019-06-03 7:45 ` Peter Ujfalusi
0 siblings, 2 replies; 4+ messages in thread
From: Tony Lindgren @ 2019-05-30 6:56 UTC (permalink / raw)
To: linux-omap
Cc: Benoît Cousson, devicetree, Peter Ujfalusi, Tero Kristo,
Tomi Valkeinen
There is no CLKSEL for timer12 on dra6 unlike for timer1. This
causes issues on booting the device that Tomi noticed if
DEBUG_SLAB is enabled and the clkctrl clock does not properly
handle non-existing clock. Let's drop the bogus CLKSEL clock,
the clkctrl clock handling gets fixed separately.
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reported-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Fixes: 4ed0dfe3cf39 ("ARM: dts: dra7: Move l4 child devices to probe them with ti-sysc")
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/boot/dts/dra7-l4.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
--- a/arch/arm/boot/dts/dra7-l4.dtsi
+++ b/arch/arm/boot/dts/dra7-l4.dtsi
@@ -4450,8 +4450,6 @@
timer12: timer@0 {
compatible = "ti,omap5430-timer";
reg = <0x0 0x80>;
- clocks = <&wkupaon_clkctrl DRA7_WKUPAON_TIMER12_CLKCTRL 24>;
- clock-names = "fck";
interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
ti,timer-alwon;
ti,timer-secure;
--
2.21.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: Drop bogus CLKSEL for timer12 on dra7
2019-05-30 6:56 [PATCH] ARM: dts: Drop bogus CLKSEL for timer12 on dra7 Tony Lindgren
@ 2019-05-31 12:05 ` Tomi Valkeinen
2019-06-11 6:37 ` Tony Lindgren
2019-06-03 7:45 ` Peter Ujfalusi
1 sibling, 1 reply; 4+ messages in thread
From: Tomi Valkeinen @ 2019-05-31 12:05 UTC (permalink / raw)
To: Tony Lindgren, linux-omap
Cc: Benoît Cousson, devicetree, Peter Ujfalusi, Tero Kristo
On 30/05/2019 09:56, Tony Lindgren wrote:
> There is no CLKSEL for timer12 on dra6 unlike for timer1. This
dra7
> causes issues on booting the device that Tomi noticed if
> DEBUG_SLAB is enabled and the clkctrl clock does not properly
> handle non-existing clock. Let's drop the bogus CLKSEL clock,
> the clkctrl clock handling gets fixed separately.
>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Reported-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Fixes: 4ed0dfe3cf39 ("ARM: dts: dra7: Move l4 child devices to probe them with ti-sysc")
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/boot/dts/dra7-l4.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
> --- a/arch/arm/boot/dts/dra7-l4.dtsi
> +++ b/arch/arm/boot/dts/dra7-l4.dtsi
> @@ -4450,8 +4450,6 @@
> timer12: timer@0 {
> compatible = "ti,omap5430-timer";
> reg = <0x0 0x80>;
> - clocks = <&wkupaon_clkctrl DRA7_WKUPAON_TIMER12_CLKCTRL 24>;
> - clock-names = "fck";
> interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> ti,timer-alwon;
> ti,timer-secure;
>
Tested-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: Drop bogus CLKSEL for timer12 on dra7
2019-05-30 6:56 [PATCH] ARM: dts: Drop bogus CLKSEL for timer12 on dra7 Tony Lindgren
2019-05-31 12:05 ` Tomi Valkeinen
@ 2019-06-03 7:45 ` Peter Ujfalusi
1 sibling, 0 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2019-06-03 7:45 UTC (permalink / raw)
To: Tony Lindgren, linux-omap
Cc: Benoît Cousson, devicetree, Tero Kristo, Tomi Valkeinen
On 30/05/2019 9.56, Tony Lindgren wrote:
> There is no CLKSEL for timer12 on dra6 unlike for timer1. This
> causes issues on booting the device that Tomi noticed if
> DEBUG_SLAB is enabled and the clkctrl clock does not properly
> handle non-existing clock. Let's drop the bogus CLKSEL clock,
> the clkctrl clock handling gets fixed separately.
Tested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Reported-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Fixes: 4ed0dfe3cf39 ("ARM: dts: dra7: Move l4 child devices to probe them with ti-sysc")
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/boot/dts/dra7-l4.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
> --- a/arch/arm/boot/dts/dra7-l4.dtsi
> +++ b/arch/arm/boot/dts/dra7-l4.dtsi
> @@ -4450,8 +4450,6 @@
> timer12: timer@0 {
> compatible = "ti,omap5430-timer";
> reg = <0x0 0x80>;
> - clocks = <&wkupaon_clkctrl DRA7_WKUPAON_TIMER12_CLKCTRL 24>;
> - clock-names = "fck";
> interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> ti,timer-alwon;
> ti,timer-secure;
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-11 6:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-30 6:56 [PATCH] ARM: dts: Drop bogus CLKSEL for timer12 on dra7 Tony Lindgren
2019-05-31 12:05 ` Tomi Valkeinen
2019-06-11 6:37 ` Tony Lindgren
2019-06-03 7:45 ` Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).