From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC Date: Tue, 11 Jun 2019 13:47:29 +0200 Message-ID: <20190611114729.GC31772@zn.tnic> References: <1559211329-13098-1-git-send-email-hhhawa@amazon.com> <1559211329-13098-3-git-send-email-hhhawa@amazon.com> <20190531051400.GA2275@cz.tnic> <32431fa2-2285-6c41-ce32-09630205bb54@arm.com> <9a2aaf4a9545ed30568a0613e64bc3f57f047799.camel@kernel.crashing.org> <20190608090556.GA32464@zn.tnic> <1ae5e7a3464f9d8e16b112cd371957ea20472864.camel@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1ae5e7a3464f9d8e16b112cd371957ea20472864.camel@kernel.crashing.org> Sender: linux-kernel-owner@vger.kernel.org To: Benjamin Herrenschmidt Cc: James Morse , "Hawa, Hanna" , "robh+dt@kernel.org" , "Woodhouse, David" , "paulmck@linux.ibm.com" , "mchehab@kernel.org" , "mark.rutland@arm.com" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "nicolas.ferre@microchip.com" , "devicetree@vger.kernel.org" , "Shenhar, Talel" , "linux-kernel@vger.kernel.org" , "Chocron, Jonathan" , "Krupnik, Ronen" , "linux-edac@vger.kernel.org" , Hanoch, Uri List-Id: devicetree@vger.kernel.org On Tue, Jun 11, 2019 at 03:50:40PM +1000, Benjamin Herrenschmidt wrote: > Should we fix that then instead ? Sure. > What are the big issues with adding some basic locking ? being called > from NMIs ? That is one possible issue. I know we don't call the error decoding routines in NMI context on x86 but no clue about ARM. > If the separate drivers operate on distinct counters I don't see a big > problem there. Yes, and they do. > I'n not sure why ... Well, however you'd call it. It will be some distinct name I hope :) -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.