Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC

Joe Perches
2019-05-30T13:04:00Z

On Thu, 2019-05-30 at 15:52 +0300, hhhawa@amazon.com wrote:
> On 5/30/19 2:57 PM, Greg KH wrote:
> > On Thu, May 30, 2019 at 01:15:29PM +0300, Hanna Hawa wrote:
> > > +static void al_a57_edac_cpumerrsr(void *arg)
> > > +{
> > > + struct edac_device_ctl_info *edac_dev =
> > > + (struct edac_device_ctl_info *)arg;
> > No need for casting anything here, just assign it. Doesn't checkpatch
> > catch this type of thing these days? You did run it, right?
>
> I did, but checkpatch didn't catch this. I'll fix in next patch-set.
>
> Thanks for your review.

checkpatch is brainless about the types of variables/arguments.

coccinelle is another very useful tool so you could also run
scripts/coccicheck on your sources.

see: Documentation/dev-tools/coccinelle.rst