From: Michael Drake <michael.drake@codethink.co.uk>
To: Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Michael Drake <michael.drake@codethink.co.uk>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@lists.codethink.co.uk,
Patrick Glaser <pglaser@tesla.com>, Nate Case <ncase@tesla.com>
Subject: [PATCH v1 05/11] ti948: Add alive check function using schedule_delayed_work()
Date: Tue, 11 Jun 2019 15:04:06 +0100 [thread overview]
Message-ID: <20190611140412.32151-6-michael.drake@codethink.co.uk> (raw)
In-Reply-To: <20190611140412.32151-1-michael.drake@codethink.co.uk>
This simply runs the function once every 5 seconds, while the
device is supposed to be active. The alive check function is
currently simply a stub, that logs it has been called, and
re-inserts itself into the work queue.
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Cc: Patrick Glaser <pglaser@tesla.com>
Cc: Nate Case <ncase@tesla.com>
---
drivers/gpu/drm/bridge/ti948.c | 37 +++++++++++++++++++++++++++++++++-
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti948.c b/drivers/gpu/drm/bridge/ti948.c
index 9cb37215f049..86daa3701b91 100644
--- a/drivers/gpu/drm/bridge/ti948.c
+++ b/drivers/gpu/drm/bridge/ti948.c
@@ -16,6 +16,7 @@
#include <linux/regulator/consumer.h>
#include <linux/of_device.h>
+#include <linux/workqueue.h>
#include <linux/module.h>
#include <linux/regmap.h>
#include <linux/delay.h>
@@ -25,6 +26,9 @@
/* Number of times to try checking for device on bringup. */
#define TI948_DEVICE_ID_TRIES 10
+/* Alive check every 5 seconds. */
+#define TI948_ALIVE_CHECK_DELAY (5 * HZ)
+
/**
* enum ti948_reg - TI948 registers.
*
@@ -374,9 +378,27 @@ static inline struct ti948_ctx *ti948_ctx_from_dev(struct device *dev)
return i2c_get_clientdata(client);
}
+static inline struct ti948_ctx *delayed_work_to_ti948_ctx(
+ struct delayed_work *dwork)
+{
+ return container_of(dwork, struct ti948_ctx, alive_check);
+}
+
+static void ti948_alive_check(struct work_struct *work)
+{
+ struct delayed_work *dwork = to_delayed_work(work);
+ struct ti948_ctx *ti948 = delayed_work_to_ti948_ctx(dwork);
+
+ dev_info(&ti948->i2c->dev, "%s Alive check!\n", __func__);
+
+ /* Reschedule ourself for the next check. */
+ schedule_delayed_work(&ti948->alive_check, TI948_ALIVE_CHECK_DELAY);
+}
+
static int ti948_pm_resume(struct device *dev)
{
struct ti948_ctx *ti948 = ti948_ctx_from_dev(dev);
+ bool scheduled;
int ret;
if (ti948 == NULL)
@@ -386,7 +408,18 @@ static int ti948_pm_resume(struct device *dev)
if (ret != 0)
return ret;
- return ti948_write_config_seq(ti948);
+ ret = ti948_write_config_seq(ti948);
+ if (ret != 0)
+ return ret;
+
+ INIT_DELAYED_WORK(&ti948->alive_check, ti948_alive_check);
+
+ scheduled = schedule_delayed_work(
+ &ti948->alive_check, TI948_ALIVE_CHECK_DELAY);
+ if (!scheduled)
+ dev_warn(&ti948->i2c->dev, "Alive check already scheduled\n");
+
+ return 0;
}
static int ti948_pm_suspend(struct device *dev)
@@ -396,6 +429,8 @@ static int ti948_pm_suspend(struct device *dev)
if (ti948 == NULL)
return 0;
+ cancel_delayed_work_sync(&ti948->alive_check);
+
return ti948_power_off(ti948);
}
--
2.20.1
next prev parent reply other threads:[~2019-06-11 14:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 14:04 [PATCH v1 00/11] Add ti948 and ti949 display bridge drivers Michael Drake
2019-06-11 14:04 ` [PATCH v1 01/11] dt-bindings: display/bridge: Add bindings for ti948 Michael Drake
2019-06-11 18:03 ` Laurent Pinchart
2019-07-12 12:42 ` Michael Drake
2019-06-11 14:04 ` [PATCH v1 02/11] ti948: i2c device driver for TI DS90UB948-Q1 Michael Drake
2019-06-11 14:04 ` [PATCH v1 03/11] dt-bindings: display/bridge: Add config property for ti948 Michael Drake
2019-06-11 18:07 ` Laurent Pinchart
2019-07-12 12:43 ` Michael Drake
2019-06-11 14:04 ` [PATCH v1 04/11] ti948: Add support for configuration via device properties Michael Drake
2019-06-11 14:04 ` Michael Drake [this message]
2019-06-11 14:04 ` [PATCH v1 06/11] ti948: Reconfigure in the alive check when device returns Michael Drake
2019-06-11 18:10 ` Laurent Pinchart
2019-07-12 12:43 ` Michael Drake
2019-06-11 14:04 ` [PATCH v1 07/11] ti948: Add sysfs node for alive attribute Michael Drake
2019-06-11 18:11 ` Laurent Pinchart
2019-07-12 12:43 ` Michael Drake
2019-06-11 14:04 ` [PATCH v1 08/11] dt-bindings: display/bridge: Add bindings for ti949 Michael Drake
2019-06-11 18:13 ` Laurent Pinchart
2019-07-12 12:43 ` Michael Drake
2019-06-11 14:04 ` [PATCH v1 09/11] ti949: i2c device driver for TI DS90UB949-Q1 Michael Drake
2019-06-11 14:04 ` [PATCH v1 10/11] dt-bindings: display/bridge: Add config property for ti949 Michael Drake
2019-06-11 14:04 ` [PATCH v1 11/11] ti949: Add support for configuration via device properties Michael Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611140412.32151-6-michael.drake@codethink.co.uk \
--to=michael.drake@codethink.co.uk \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ncase@tesla.com \
--cc=pglaser@tesla.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).