From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag MSI_FLAG_MULTI_PCI_MSI Date: Tue, 11 Jun 2019 17:59:43 +0100 Message-ID: <20190611165935.GA22836@redmoon> References: <20190412083635.33626-1-Zhiqiang.Hou@nxp.com> <20190412083635.33626-5-Zhiqiang.Hou@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190412083635.33626-5-Zhiqiang.Hou@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: "Z.q. Hou" Cc: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "l.subrahmanya@mobiveil.co.in" , "shawnguo@kernel.org" , Leo Li , "catalin.marinas@arm.com" , "will.deacon@arm.com" , Mingkai Hu , "M.h. Lian" , Xiaowei Bao List-Id: devicetree@vger.kernel.org On Fri, Apr 12, 2019 at 08:35:36AM +0000, Z.q. Hou wrote: > From: Hou Zhiqiang > > The current code does not support multiple MSIs, so remove > the corresponding flag from the msi_domain_info structure. Please explain me what's the problem before removing multi MSI support. Thanks, Lorenzo > Fixes: 1e913e58335f ("PCI: mobiveil: Add MSI support") > Signed-off-by: Hou Zhiqiang > Reviewed-by: Minghuan Lian > --- > V5: > - Corrected the subject. > > drivers/pci/controller/pcie-mobiveil.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c > index 563210e731d3..a0dd337c6214 100644 > --- a/drivers/pci/controller/pcie-mobiveil.c > +++ b/drivers/pci/controller/pcie-mobiveil.c > @@ -703,7 +703,7 @@ static struct irq_chip mobiveil_msi_irq_chip = { > > static struct msi_domain_info mobiveil_msi_domain_info = { > .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | > - MSI_FLAG_MULTI_PCI_MSI | MSI_FLAG_PCI_MSIX), > + MSI_FLAG_PCI_MSIX), > .chip = &mobiveil_msi_irq_chip, > }; > > -- > 2.17.1 >