From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH 1/3] dt-bindings: imx: Add pinctrl binding doc for i.MX8MN Date: Wed, 12 Jun 2019 14:05:29 +0800 Message-ID: <20190612060522.GB11086@dragon> References: <20190530030546.9224-1-Anson.Huang@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Aisheng Dong Cc: Mark Rutland , Maxime Ripard , Catalin Marinas , Linus Walleij , Will Deacon , Stefan Agner , Bjorn Andersson , Leonard Crestez , Fabio Estevam , Anson Huang , Olof Johansson , Jagan Teki , dl-linux-imx , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sascha Hauer , "open list:GPIO SUBSYSTEM" , Rob Herring , Simon Horman , Linux ARM , "linux-kernel@vger.kernel.org" , Dinh List-Id: devicetree@vger.kernel.org On Tue, Jun 11, 2019 at 10:00:36AM +0000, Aisheng Dong wrote: > > From: Linus Walleij [mailto:linus.walleij@linaro.org] > > Sent: Saturday, June 8, 2019 5:04 AM > > > > On Thu, May 30, 2019 at 5:04 AM wrote: > > > > > From: Anson Huang > > > > > > Add binding doc for i.MX8MN pinctrl driver. > > > > > > Signed-off-by: Anson Huang > > > > Looks mostly OK to me, but I'd like the maintainers to review, so Dong et al > > please look at this! > > > > > +Required properties: > > > +- compatible: "fsl,imx8mn-iomuxc" > > > > So should this not be "nxp,imx8mn-iomuxc" > > or "nxp,freescale-imx8mn-iomuxc" or something these days? The vendor name > > is nxp is it not. > > > > I was complaining to the DT maintainers at one point that these companies > > seem to buy each other left and right so this vendor nomenclature is dubious, > > but I guess at least it should reflect the vendor that produced the chip or > > something. > > > > If everyone is happy with "fsl,*" I will not complain though. > > (i.e. if the maintainers ACK it.) > > We preferred to keep "fsl,*" for Freescale i.MX product line according to last discussion. > And we already did this way for most i.MX devices. +1 We do not see serious problem with 'fsl' prefix, so would rather stay with it. Shawn