From: Tony Lindgren <tony@atomide.com>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: linux-omap@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, peter.ujfalusi@ti.com
Subject: Re: [PATCH] ARM: dts: am335x-baltos: Fix PHY mode for ethernet
Date: Wed, 12 Jun 2019 01:52:16 -0700 [thread overview]
Message-ID: <20190612085216.GE5447@atomide.com> (raw)
In-Reply-To: <CAGm1_kufcx3siXKc6EtFJhLQ_K+V7MgVtvZuXeN2YikkPcufmg@mail.gmail.com>
* Yegor Yefremov <yegorslists@googlemail.com> [190612 08:21]:
> Hi Tony,
>
> On Wed, Jun 12, 2019 at 10:04 AM Tony Lindgren <tony@atomide.com> wrote:
> >
> > Hi,
> >
> > * yegorslists@googlemail.com <yegorslists@googlemail.com> [190611 02:31]:
> > > From: Yegor Yefremov <yegorslists@googlemail.com>
> > >
> > > The PHY must add both tx and rx delay and not only on the tx clock.
> >
> > As we're close to -rc5, I applied this against v5.2-rc1 and merged into
> > omap-for-v5.3/dt as it seems it's optional or has been broken for a while
> > with no fixes tag. After it hits the mainline kernel during the merge
> > window you can request it be applied into the stable trees as needed.
> >
> > However, if this is urgent, let me know what regression it fixes and
> > I'll merge it into my fixes branch too.
>
> This is the same fix as 759c962d3c9bb1a60e3b4b780daa66ee6d4be13a:
>
> ARM: dts: am335x-evmsk: Fix PHY mode for ethernet
>
> The PHY must add both tx and rx delay and not only on the tx clock.
> The board uses AR8031_AL1A PHY where the rx delay is enabled by default,
> the tx dealy is disabled.
>
> The reason why rgmii-txid worked because the rx delay was not disabled by
> the driver so essentially we ended up with rgmii-id PHY mode.
>
> It seems to be working in 4.19. So I think kernels 5.0, 5.1 are the
> first to be affected. Without this patch eth1 is not working on Baltos
> devices.
OK thanks so it's pretty regression recent then, I'll merge it into fixes
too.
Regards,
Tony
prev parent reply other threads:[~2019-06-12 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 9:30 [PATCH] ARM: dts: am335x-baltos: Fix PHY mode for ethernet yegorslists
2019-06-12 8:04 ` Tony Lindgren
2019-06-12 8:20 ` Yegor Yefremov
2019-06-12 8:52 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612085216.GE5447@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).