Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC

Hawa, Hanna
2019-06-06T07:53:42Z

On 5/31/2019 8:14 AM, Borislav Petkov wrote:
> On Fri, May 31, 2019 at 01:15:33AM +0000, Herrenschmidt, Benjamin wrote:
>> This isn't terribly helpful, there's nothing telling anybody which of
>> those files corresponds to an ARM SoC :-)
>
> drivers/edac/altera_edac.c is one example.
>
> Also, James and I have a small writeup on how an arm driver should look
> like, we just need to polish it up and post it.
>
> James?
>
>> That said ...
>>
>> You really want a single EDAC driver that contains all the stuff for
>> the caches, the memory controller, etc... ?
>
> Yap.

Disagree. The various drivers don't depend on each other.
I think we should keep the drivers separated as they are distinct and
independent IP blocks.

>