From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1 Date: Wed, 12 Jun 2019 21:38:22 +0800 Message-ID: <20190612132705.GJ11086@dragon> References: <20190606090612.16685-1-igor.opaniuk@gmail.com> <3b84f3cc6cd5399f25ebd8e1c8559c58@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Igor Opaniuk Cc: Stefan Agner , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linux ARM , robh+dt@kernel.org, mark.rutland@arm.com, s.hauer@pengutronix.de, kernel@pengutronix.de, Fabio Estevam , linux-imx@nxp.com, Marcel Ziswiler , Marcel Ziswiler List-Id: devicetree@vger.kernel.org On Wed, Jun 12, 2019 at 03:49:03PM +0300, Igor Opaniuk wrote: > Hi Stefan, > > On Wed, Jun 12, 2019 at 3:17 PM Stefan Agner wrote: > > > > On 06.06.2019 11:06, Igor Opaniuk wrote: > > > From: Igor Opaniuk > > > > > > Allows to use the SD interface at a higher speed mode if the card > > > supports it. For this the signaling voltage is switched from 3.3V to > > > 1.8V under the usdhc1's drivers control. > > > > > > Signed-off-by: Igor Opaniuk > > > --- > > > arch/arm/boot/dts/imx6ul.dtsi | 4 ++++ > > > arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 11 +++++++++-- > > > arch/arm/boot/dts/imx6ull-colibri.dtsi | 6 ++++++ > > > 3 files changed, 19 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi > > > index fc388b84bf22..91a0ced44e27 100644 > > > --- a/arch/arm/boot/dts/imx6ul.dtsi > > > +++ b/arch/arm/boot/dts/imx6ul.dtsi > > > @@ -857,6 +857,8 @@ > > > <&clks IMX6UL_CLK_USDHC1>, > > > <&clks IMX6UL_CLK_USDHC1>; > > > clock-names = "ipg", "ahb", "per"; > > > + fsl,tuning-step= <2>; > > > + fsl,tuning-start-tap = <20>; > > > bus-width = <4>; > > > status = "disabled"; > > > }; > > > @@ -870,6 +872,8 @@ > > > <&clks IMX6UL_CLK_USDHC2>; > > > clock-names = "ipg", "ahb", "per"; > > > bus-width = <4>; > > > + fsl,tuning-step= <2>; > > > + fsl,tuning-start-tap = <20>; > > > status = "disabled"; > > > }; > > > > > > diff --git a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi > > > b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi > > > index 006690ea98c0..7dc7770cf52c 100644 > > > --- a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi > > > +++ b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi > > > @@ -145,13 +145,20 @@ > > > }; > > > > > > &usdhc1 { > > > - pinctrl-names = "default"; > > > + pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep"; > > > pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_cd>; > > > - no-1-8-v; > > > + pinctrl-1 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>; > > > + pinctrl-2 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>; > > > > Should that not be pinctrl_usdhc1_200mhz? > > > > Correct, thanks for pointing this out. > Taking into account that the patch was already accepted by Shawn, will > send another to fix this typo ASAP (added to my todo list). I just fixed it up on my branch. Shawn