From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas Date: Wed, 12 Jun 2019 17:38:18 +0200 Message-ID: <20190612153818.q5xj5su33krlignu@flea> References: <20190605122936.11972-1-maxime.ripard@bootlin.com> <20190611090641.byr6mpywkfmbhrbk@flea> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5426759145756999558==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, Wolfram Sang , Gregory Clement , Chen-Yu Tsai , Linux I2C , Frank Rowand , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" List-Id: devicetree@vger.kernel.org --===============5426759145756999558== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jqnskoivfbu5krfp" Content-Disposition: inline --jqnskoivfbu5krfp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Tue, Jun 11, 2019 at 08:50:37AM -0600, Rob Herring wrote: > On Tue, Jun 11, 2019 at 3:06 AM Maxime Ripard wrote: > > > > Hi Rob, > > > > On Mon, Jun 10, 2019 at 03:34:18PM -0600, Rob Herring wrote: > > > On Wed, Jun 5, 2019 at 6:29 AM Maxime Ripard wrote: > > > > +properties: > > > > + "#address-cells": > > > > + const: 1 > > > > + > > > > + "#size-cells": > > > > + const: 0 > > > > > > These 2 are covered by i2c-controller.yaml, right? > > > > Indeed, I've removed them. > > > > > > +examples: > > > > + - | > > > > + p2wi@1f03400 { > > > > > > i2c@... > > > > > > That should fail on the schema (I need to get the schema checking of > > > examples finished.) > > > > That would be great :) The compilation of the examples alone already > > caught a good number of examples that weren't even compiling. > > I'm primarily waiting on a dtc change to be accepted[1]. Feel free to > review/ack. I guess it's too late now :) > > Speaking of examples, one thing that would be great too would be to > > allow the usage of our C headers. It's not supported at the moment, > > and this often ends up with an example that is less readable than the > > actual DT. > > It should be. You just have to add them. See > Documentation/devicetree/bindings/timer/intel,ixp4xx-timer.yaml for > example. Hmmm, I'm pretty sure I tried this before. I'll try again. > Maybe the common interrupt and gpio ones should be added by default. I guess so, yeah. The GIC too is pretty common Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --jqnskoivfbu5krfp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXQEcaQAKCRDj7w1vZxhR xWTgAP9WB+1aXtMSPMtLHzMJKOV6r1RNowdkygnwiE+cBDkvOAD7BDqmviqSzzZt 6saIUD3M+DBgvkUTsko4s0nJ4Wp+1AQ= =GewT -----END PGP SIGNATURE----- --jqnskoivfbu5krfp-- --===============5426759145756999558== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5426759145756999558==--