From: Thierry Reding <thierry.reding@gmail.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH 1/3] arm64: tegra: Add ethernet alias on Jetson TX1
Date: Thu, 13 Jun 2019 18:34:52 +0200 [thread overview]
Message-ID: <20190613163452.GA3258@ulmo> (raw)
In-Reply-To: <04a355c8-a4ae-9275-a85a-791ce5c1b34c@wwwdotorg.org>
[-- Attachment #1.1: Type: text/plain, Size: 1629 bytes --]
On Thu, Jun 13, 2019 at 10:22:23AM -0600, Stephen Warren wrote:
> On 6/13/19 10:15 AM, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Adding this alias for the Ethernet interface on Jetson TX1 allows the
> > bootloader to pass the MAC address to the Linux kernel.
>
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
>
> > + aliases {
> > + ethernet = "/usb@70090000/ethernet@1";
> > + };
>
> Don't aliases require an ID in the property name, i.e shouldn't this be
> "ethernet0" rather than just "ethernet"? This is a bit more obvious in the
> TX2 patch where sdhci0, sdhci1, and serial0 are shown in the diff context.
I don't think there's a requirement for aliases to have an ID. The IDs,
in the cases that I'm aware of, are used to fix the index given to the
controllers in Linux (which is sometimes abused to get fixed numbering
that can be hardcoded, rather than having a more robust way to look up
the right hardware block).
U-Boot has a comment somewhere about ethernet being equivalent to
ethernet0 and it treats them the same way, if I remember correctly.
As for upstream Linux, there does indeed seem to be a slight tendency
towards ethernet0, though it's pretty well mixed. 32-bit ARM is mostly
balanced, whereas 64-bit ARM uses ethernet0 almost exclusively. Maybe
this means that recently there's been a push to standardize on always
adding the index?
> Patch should probably be CC'd to some/all of ARM/DT/... mailing lists?
Oops... I meant to include those. Added now.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
parent reply other threads:[~2019-06-13 16:34 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <04a355c8-a4ae-9275-a85a-791ce5c1b34c@wwwdotorg.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613163452.GA3258@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).