From: Jacopo Mondi <jacopo@jmondi.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-media@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
James Cameron <quozl@laptop.org>, Pavel Machek <pavel@ucw.cz>,
Libin Yang <lbyang@marvell.com>,
Albert Wang <twang13@marvell.com>,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: [PATCH v5 03/10] [media] marvell-ccic: don't generate EOF on parallel bus
Date: Fri, 14 Jun 2019 12:01:33 +0200 [thread overview]
Message-ID: <20190614100133.euxhdaktlemnd2ep@uno.localdomain> (raw)
In-Reply-To: <20190505140031.9636-4-lkundrak@v3.sk>
[-- Attachment #1: Type: text/plain, Size: 2065 bytes --]
Hi Lubomir,
On Sun, May 05, 2019 at 04:00:24PM +0200, Lubomir Rintel wrote:
> The commit 05fed81625bf ("[media] marvell-ccic: add MIPI support for
> marvell-ccic driver") that claimed to add CSI2 turned on C0_EOF_VSYNC for
> parallel bus without a very good explanation.
>
> That broke camera on OLPC XO-1.75 which precisely uses a sensor on a
> parallel bus. Revert that chunk.
>
> Tested on an OLPC XO-1.75.
>
> Fixes: 05fed81625bf755cc67c5864cdfd18b69ea828d1
Use the proper fixes format here
Fixes: 05fed81625bf ("[media] marvell-ccic: add MIPI support for marvell-ccic driver")
I have this simple entry in my git config:
[pretty]
fixes = Fixes: %h (\"%s\")
With
abbrev=12
in the [core] section.
You can now
$git show 05fed81625bf755cc67c5864cdfd18b69ea828d1 --pretty=fixes
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> drivers/media/platform/marvell-ccic/mcam-core.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c
> index d97f39bde9bd6..d24e5b7a3bc52 100644
> --- a/drivers/media/platform/marvell-ccic/mcam-core.c
> +++ b/drivers/media/platform/marvell-ccic/mcam-core.c
> @@ -792,12 +792,6 @@ static void mcam_ctlr_image(struct mcam_camera *cam)
> * Make sure it knows we want to use hsync/vsync.
> */
> mcam_reg_write_mask(cam, REG_CTRL0, C0_SIF_HVSYNC, C0_SIFM_MASK);
> - /*
> - * This field controls the generation of EOF(DVP only)
> - */
> - if (cam->bus_type != V4L2_MBUS_CSI2_DPHY)
> - mcam_reg_set_bit(cam, REG_CTRL0,
> - C0_EOF_VSYNC | C0_VEDGE_CTRL);
This change seems in facts unrelated to the original patch. As you
remove all usages of C0_EOF_VSYNC and C0_VEDGE_CTRL you can drop their
definition in mcam-core.h.
As I've said, the change seems unrelated to CSI-2 support and could
probably be salfey dropped, but pay attention, you're also dropping
C0_VEDGE_CTRL, which seems to enable VSYNC detection on the signal
falling edge. Is this intentional ?
Thanks
j
> }
>
>
> --
> 2.21.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-14 10:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 14:00 [PATCH v5 00/10] media: make Marvell camera work on DT-based OLPC XO-1.75 Lubomir Rintel
2019-05-05 14:00 ` [PATCH v5 01/10] media: dt-bindings: marvell,mmp2-ccic: Add Marvell MMP2 camera Lubomir Rintel
2019-05-07 17:09 ` Rob Herring
2019-06-14 9:50 ` Jacopo Mondi
2019-05-05 14:00 ` [PATCH v5 02/10] [media] marvell-ccic: fix DMA s/g desc number calculation Lubomir Rintel
2019-06-14 9:41 ` Jacopo Mondi
2019-06-19 8:16 ` Lubomir Rintel
2019-05-05 14:00 ` [PATCH v5 03/10] [media] marvell-ccic: don't generate EOF on parallel bus Lubomir Rintel
2019-06-14 10:01 ` Jacopo Mondi [this message]
2019-05-05 14:00 ` [PATCH v5 04/10] Revert "[media] marvell-ccic: reset ccic phy when stop streaming for stability" Lubomir Rintel
2019-05-05 14:00 ` [PATCH v5 05/10] [media] marvell-ccic: drop unused stuff Lubomir Rintel
2019-05-05 14:00 ` [PATCH v5 06/10] [media] marvell-ccic/mmp: enable clock before accessing registers Lubomir Rintel
2019-05-05 14:00 ` [PATCH v5 07/10] [media] marvell-ccic: rename the clocks Lubomir Rintel
2019-05-05 14:00 ` [PATCH v5 08/10] [media] marvell-ccic/mmp: add devicetree support Lubomir Rintel
2019-05-05 14:00 ` [PATCH v5 09/10] [media] marvell-ccic: use async notifier to get the sensor Lubomir Rintel
2019-05-05 14:00 ` [PATCH v5 10/10] [media] marvell-ccic: provide a clock for " Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614100133.euxhdaktlemnd2ep@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=lbyang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pavel@ucw.cz \
--cc=quozl@laptop.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=twang13@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).