From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 3/3] media: dt-bindings: media: i2c: Add bindings for ov02a10 Date: Fri, 14 Jun 2019 10:56:03 -0600 Message-ID: <20190614165603.GA30462@bogus> References: <20190523102204.24112-1-dongchun.zhu@mediatek.com> <20190523102204.24112-4-dongchun.zhu@mediatek.com> <20190531161658.2y2amfngbhfbllj7@valkosipuli.retiisi.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190531161658.2y2amfngbhfbllj7@valkosipuli.retiisi.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sakari Ailus Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, menghui.lin@mediatek.com, shengnan.wang@mediatek.com, louis.kuo@mediatek.com, sj.huang@mediatek.com, linux-mediatek@lists.infradead.org, dongchun.zhu@mediatek.com, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org On Fri, May 31, 2019 at 07:16:58PM +0300, Sakari Ailus wrote: > Hi Dongchun, > > Thanks for the patch. > > On Thu, May 23, 2019 at 06:22:04PM +0800, dongchun.zhu@mediatek.com wrote: > > From: Dongchun Zhu > > > > Add device tree binding documentation for the OV02A10 CMOS image sensor. > > > > Signed-off-by: Dongchun Zhu > > --- > > .../devicetree/bindings/media/i2c/ov02a10.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov02a10.txt > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov02a10.txt b/Documentation/devicetree/bindings/media/i2c/ov02a10.txt > > new file mode 100644 > > index 0000000..fdc2904 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/ov02a10.txt > > @@ -0,0 +1,43 @@ > > +* Omnivision OV02A10 MIPI CSI-2 sensor > > + > > +Required Properties: > > +- compatible: shall be "ovti,ov02a10" > > +- clocks: reference to the xvclk input clock > > +- clock-names: shall be "xvclk" > > +- avdd-supply: Analog voltage supply, 2.8 volts > > +- dovdd-supply: Digital I/O voltage supply, 1.8 volts > > +- dvdd-supply: Digital core voltage supply, 1.8 volts > > +- reset-gpios: Low active reset gpio > > + > > +The device node shall contain one 'port' child node with an > > +'endpoint' subnode for its digital output video port, > > +in accordance with the video interface bindings defined in > > +Documentation/devicetree/bindings/media/video-interfaces.txt. > > +The endpoint optional property 'data-lanes' shall be "<1>". > > If the sensor only supports a single lane configuration (one lane), you can > omit that property altogether. Is that the only possible configuration for > the sensor? > > Please also wrap the text at 80 characters, not 65 or so. > > > + > > +Example: > > +&i2c4 { > > + sensor_sub: sensor_sub { > > camera-sensor@3d { > > > + compatible = "ovti,ov02a10"; > > + reg = <0x3d>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&camera_pins_cam1_mclk_on>; > > + > > + clocks = <&topckgen CLK_TOP_MUX_CAMTG2>, > > + <&topckgen CLK_TOP_UNIVP_192M_D8>; > > + clock-names = "xvclk", "freq_mux"; > > + > > + avdd-supply = <&mt6358_vcama1_reg>; > > + dvdd-supply = <&mt6358_vcn18_reg>; > > + dovdd-supply = <&mt6358_vcamio_reg>; > > + pwdn-gpios = <&pio 107 1>; > > + reset-gpios = <&pio 109 1>; > > + > > + port@0 { Also, drop the unit-address as there is no 'reg' property. Building your dts file will 'W=1' will tell you this. > > + ov02a10_core: endpoint { > > + remote-endpoint = <&ov02a10_0>; > > + data-lanes = <1>; > > + }; > > Tabs for indentation, please. > > > + }; > > + }; > > +}; > > -- > Kind regards, > > Sakari Ailus