From: Rob Herring <robh@kernel.org>
To: Leif Middelschulte <leif.middelschulte@klsmartin.com>
Cc: dmitry.torokhov@gmail.com, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, mark.rutland@arm.com
Subject: Re: [PATCH 01/10] dt-bindings: input: touchscreen: stmpe: add touch window configuration
Date: Fri, 14 Jun 2019 13:48:18 -0600 [thread overview]
Message-ID: <20190614194818.GA22146@bogus> (raw)
In-Reply-To: <20190527160736.30569-2-leif.middelschulte@klsmartin.com>
On Mon, May 27, 2019 at 06:07:27PM +0200, Leif Middelschulte wrote:
> The STMPE811 is able to only monitor a subwindow of the
> entire screen. Touches outside of this window are neglected.
> This change adds the corresponding documentation.
Unless you are trying to just filter out the edge values which I think
we already have properties for, wouldn't this be something the user
may want to adjust/move at runtime?
>
> Signed-off-by: Leif Middelschulte <leif.middelschulte@klsmartin.com>
> ---
> .../devicetree/bindings/input/touchscreen/stmpe.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt b/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> index c549924603d2..04962e2e1ad0 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> @@ -33,6 +33,13 @@ Optional properties:
> - st,i-drive : current limit value of the touchscreen drivers
> 0 -> 20 mA (typical 35mA max)
> 1 -> 50 mA (typical 80 mA max)
> +- st,window-tracking : An u12 array that allows to pre-set a sub-window in the touchscreen.
u16?
> + Any touch position that is outside the sub-window is discarded
> + (top-right x, top-right y, bottom-left x, bottom-left y).
> + The given window also affects the value range (limits) set
> + within the input subsystem which, in turn, affects
> + the input resolution calculation on both axes.
> +
>
> Optional properties common with MFD (deprecated):
> - st,sample-time : ADC conversion time in number of clock.
> @@ -101,6 +108,8 @@ stmpe811@41 {
> * current limit value
> */
> st,i-drive = <1>;
> + /* enable entire window */
> + st,window-tracking = /bits/ 16 <4095 4095 0 0>;
> };
> stmpe_adc {
> compatible = "st,stmpe-adc";
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-06-14 19:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 16:07 [PATCH 00/10] input: touchscreen: stmpe: ext. features Leif Middelschulte
2019-05-27 16:07 ` [PATCH 01/10] dt-bindings: input: touchscreen: stmpe: add touch window configuration Leif Middelschulte
2019-06-14 19:48 ` Rob Herring [this message]
2019-06-19 11:55 ` Middelschulte, Leif
2019-06-19 13:51 ` Rob Herring
2019-06-24 10:33 ` Middelschulte, Leif
2019-05-27 16:07 ` [PATCH 02/10] Input: stmpe-ts - implement touch window configuration support Leif Middelschulte
2019-05-27 16:07 ` [PATCH 03/10] dt-bindings: input: touchscreen: stmpe: add resolution support Leif Middelschulte
2019-06-14 19:55 ` Rob Herring
2019-06-19 12:33 ` Middelschulte, Leif
2019-05-27 16:07 ` [PATCH 04/10] Input: stmpe-ts - implement " Leif Middelschulte
2019-05-27 16:19 ` [PATCH 05/10] dt-bindings: input: touchscreen: stmpe: add XY mode Leif Middelschulte
2019-05-27 16:19 ` [PATCH 06/10] Input: stmpe-ts - implement XY acquisition mode Leif Middelschulte
2019-05-27 16:19 ` [PATCH 07/10] dt-bindings: input: touchscreen: stmpe: add axes inversion and swap Leif Middelschulte
2019-06-14 19:56 ` Rob Herring
2019-05-27 16:19 ` [PATCH 08/10] Input: stmpe-ts - axes inversion and swapping Leif Middelschulte
2019-05-27 16:19 ` [PATCH 09/10] dt-bindings: input: touchscreen: stmpe: add tracking index Leif Middelschulte
2019-06-14 19:58 ` Rob Herring
2019-06-19 12:47 ` Middelschulte, Leif
2019-06-19 13:46 ` Rob Herring
2019-06-24 11:44 ` Middelschulte, Leif
2019-06-14 19:55 ` [PATCH 05/10] dt-bindings: input: touchscreen: stmpe: add XY mode Rob Herring
2019-05-27 16:22 ` [PATCH 10/10] Input: stmpe-ts - implement tracking index Leif Middelschulte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614194818.GA22146@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=leif.middelschulte@klsmartin.com \
--cc=linux-input@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).