From: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Stephen Boyd <swboyd@chromium.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH next v2] of/fdt: Fix defined but not used compiler warning
Date: Tue, 18 Jun 2019 08:09:48 -0600 [thread overview]
Message-ID: <20190618140948.GA18305@bogus> (raw)
In-Reply-To: <20190615030343.96524-1-wangkefeng.wang@huawei.com>
On Sat, 15 Jun 2019 11:03:43 +0800, Kefeng Wang wrote:
> When CONFIG_OF_EARLY_FLATTREE is disabled, there is a compiler
> warning,
>
> drivers/of/fdt.c:129:19: warning: ‘of_fdt_match’ defined but not used [-Wunused-function]
> static int __init of_fdt_match(const void *blob, unsigned long node,
>
> Since the only caller of of_fdt_match() is of_flat_dt_match(),
> let's move the body of of_fdt_match() into of_flat_dt_match()
> and eliminate of_fdt_match().
>
> Meanwhile, move of_fdt_is_compatible() under CONFIG_OF_EARLY_FLATTREE,
> as all callers are over there.
>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> v2:
> -Move the body of of_fdt_match() into of_flat_dt_match(), suggested by Frank.
>
> drivers/of/fdt.c | 99 ++++++++++++++++++++++--------------------------
> 1 file changed, 45 insertions(+), 54 deletions(-)
>
Applied, thanks.
Rob
prev parent reply other threads:[~2019-06-18 14:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 1:00 [PATCH next] of/fdt: Fix defined but not used compiler warning Kefeng Wang
2019-06-12 14:44 ` Stephen Boyd
2019-06-12 16:45 ` Frank Rowand
2019-06-12 17:00 ` Rob Herring
2019-06-12 18:29 ` Frank Rowand
2019-06-14 13:53 ` Rob Herring
2019-06-15 2:57 ` Kefeng Wang
2019-06-15 3:03 ` [PATCH next v2] " Kefeng Wang
2019-06-17 15:10 ` Stephen Boyd
2019-06-18 14:09 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618140948.GA18305@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).