From: Sam Ravnborg <sam@ravnborg.org>
To: Robert Chiras <robert.chiras@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-imx@nxp.com
Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel
Date: Wed, 19 Jun 2019 15:12:07 +0200 [thread overview]
Message-ID: <20190619131207.GA31903@ravnborg.org> (raw)
In-Reply-To: <1560864646-1468-2-git-send-email-robert.chiras@nxp.com>
Hi Robert.
Thanks for the contribution.
On Tue, Jun 18, 2019 at 04:30:45PM +0300, Robert Chiras wrote:
> Add dt-bindings documentation for Raydium RM67191 DSI panel.
>
> Signed-off-by: Robert Chiras <robert.chiras@nxp.com>
> ---
> .../bindings/display/panel/raydium,rm67191.txt | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt
> new file mode 100644
> index 0000000..0952610
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt
> @@ -0,0 +1,43 @@
> +Raydium RM67171 OLED LCD panel with MIPI-DSI protocol
> +
> +Required properties:
> +- compatible: "raydium,rm67191"
> +- reg: virtual channel for MIPI-DSI protocol
> + must be <0>
> +- dsi-lanes: number of DSI lanes to be used
> + must be <3> or <4>
> +- port: input port node with endpoint definition as
> + defined in Documentation/devicetree/bindings/graph.txt;
> + the input port should be connected to a MIPI-DSI device
> + driver
> +
> +Optional properties:
> +- reset-gpios: a GPIO spec for the RST_B GPIO pin
> +- pinctrl-0 phandle to the pin settings for the reset pin
pinctrl is not included in bindings, they are implicit.
> +- width-mm: physical panel width [mm]
> +- height-mm: physical panel height [mm]
Please refer to panel-common.txt for the above.
> +- display-timings: timings for the connected panel according to [1]
> +- video-mode: 0 - burst-mode
> + 1 - non-burst with sync event
> + 2 - non-burst with sync pulse
> +
> +[1]: Documentation/devicetree/bindings/display/panel/display-timing.txt
> +
> +Example:
> +
> + panel@0 {
> + compatible = "raydium,rm67191";
> + reg = <0>;
> + pinctrl-0 = <&pinctrl_mipi_dsi_0_1_en>;
> + pinctrl-names = "default";
> + reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
> + dsi-lanes = <4>;
> + width-mm = <68>;
> + height-mm = <121>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&mipi_out>;
> + };
> + };
> + };
With the above fixed:
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Note: You need r-b from DT maintainer before we can apply it.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-19 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 13:30 [PATCH v2 0/2] Add DSI panel driver for Raydium RM67191 Robert Chiras
2019-06-18 13:30 ` [PATCH v2 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel Robert Chiras
2019-06-19 13:12 ` Sam Ravnborg [this message]
2019-06-19 13:21 ` Fabio Estevam
2019-06-20 7:58 ` [EXT] " Robert Chiras
2019-06-18 13:30 ` [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver Robert Chiras
2019-06-19 13:25 ` Sam Ravnborg
2019-06-20 8:30 ` [EXT] " Robert Chiras
2019-06-19 13:28 ` Fabio Estevam
2019-06-20 8:34 ` [EXT] " Robert Chiras
2019-06-19 14:06 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619131207.GA31903@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robert.chiras@nxp.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).