From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver Date: Wed, 19 Jun 2019 15:25:46 +0200 Message-ID: <20190619132546.GB31903@ravnborg.org> References: <1560864646-1468-1-git-send-email-robert.chiras@nxp.com> <1560864646-1468-3-git-send-email-robert.chiras@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1560864646-1468-3-git-send-email-robert.chiras@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Robert Chiras Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Thierry Reding , linux-imx@nxp.com List-Id: devicetree@vger.kernel.org T24gVHVlLCBKdW4gMTgsIDIwMTkgYXQgMDQ6MzA6NDZQTSArMDMwMCwgUm9iZXJ0IENoaXJhcyB3 cm90ZToKPiBUaGlzIHBhdGNoIGFkZHMgUmF5ZGl1bSBSTTY3MTkxIFRGVCBMQ0QgcGFuZWwgZHJp dmVyIChNSVBJLURTSQo+IHByb3RvY29sKS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBSb2JlcnQgQ2hp cmFzIDxyb2JlcnQuY2hpcmFzQG54cC5jb20+ClBsZWFzZSBpbmNsdWRlIGluIHRoZSBjaGFuZ2Vs b2cgYSBsaXN0IG9mIHdoYXQgd2FzIHVwZGF0ZWQgLSBsaWtlIHRoaXM6Cgp2MjoKLSBhZGRlZCBr Y29uaWYgc3ltYm9sIHNvcnRlZCAoc2FtKQotIGFub3RoZXIgbml0cGljayAoZm9vKQotIGV0YwoK SW4gZ2VuZXJhbCB0cnkgdG8gbmFtbWUgd2hvIGdhdmUgZmVlZGJhY2sgdG8gZ2l2ZSB0aGVtIHNv bWUgY3JlZGl0LgoKV2hvIGlzIG1haW50YWluZXIgZm9yIHRoaXMgb253YXJkcz8KCj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9LY29uZmlnICAgICAgICAgICAgICAgICB8ICAgOSArCj4g IGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9NYWtlZmlsZSAgICAgICAgICAgICAgICB8ICAgMSArCj4g IGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1yYXlkaXVtLXJtNjcxOTEuYyB8IDcwOSArKysr KysrKysrKysrKysrKysrKysrKysrKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDcxOSBpbnNlcnRpb25z KCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtcmF5 ZGl1bS1ybTY3MTkxLmMKPiAKPiArc3RhdGljIGludCByYWRfcGFuZWxfcHJlcGFyZShzdHJ1Y3Qg ZHJtX3BhbmVsICpwYW5lbCkKPiArewo+ICsJc3RydWN0IHJhZF9wYW5lbCAqcmFkID0gdG9fcmFk X3BhbmVsKHBhbmVsKTsKPiArCj4gKwlpZiAocmFkLT5wcmVwYXJlZCkKPiArCQlyZXR1cm4gMDsK PiArCj4gKwlpZiAocmFkLT5yZXNldCkgewo+ICsJCWdwaW9kX3NldF92YWx1ZV9jYW5zbGVlcChy YWQtPnJlc2V0LCAxKTsKPiArCQl1c2xlZXBfcmFuZ2UoMzAwMCwgNTAwMCk7Cj4gKwkJZ3Bpb2Rf c2V0X3ZhbHVlX2NhbnNsZWVwKHJhZC0+cmVzZXQsIDApOwoKU28gd3JpdGluZyBhIDAgd2lsbCBy ZWxlYXNlIHJlc2V0Lgo+ICsJCXVzbGVlcF9yYW5nZSgxODAwMCwgMjAwMDApOwo+ICsJfQo+ICsK PiArCXJhZC0+cHJlcGFyZWQgPSB0cnVlOwo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICtz dGF0aWMgaW50IHJhZF9wYW5lbF91bnByZXBhcmUoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpCj4g K3sKPiArCXN0cnVjdCByYWRfcGFuZWwgKnJhZCA9IHRvX3JhZF9wYW5lbChwYW5lbCk7Cj4gKwo+ ICsJaWYgKCFyYWQtPnByZXBhcmVkKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCWlmIChyYWQtPnJl c2V0KSB7Cj4gKwkJZ3Bpb2Rfc2V0X3ZhbHVlX2NhbnNsZWVwKHJhZC0+cmVzZXQsIDEpOwo+ICsJ CXVzbGVlcF9yYW5nZSgxNTAwMCwgMTcwMDApOwo+ICsJCWdwaW9kX3NldF92YWx1ZV9jYW5zbGVl cChyYWQtPnJlc2V0LCAwKTsKTG9va3Mgc3RyYW5nZSB0aGF0IHJlc2V0IGlzIHJlbGVhc2VkIGlu IHVucHJlcGFyZS4KSSB3b3VsZCBleHBlY3QgaXQgdG8gc3RheSByZXNldCB0byBtaW5pbWl6ZSBw b3dlciBldGMuCgo+ICsKPiArCXJldCA9IGRybV9kaXNwbGF5X2luZm9fc2V0X2J1c19mb3JtYXRz KCZjb25uZWN0b3ItPmRpc3BsYXlfaW5mbywKPiArCQkJCQkgICAgICAgcmFkX2J1c19mb3JtYXRz LAo+ICsJCQkJCSAgICAgICBBUlJBWV9TSVpFKHJhZF9idXNfZm9ybWF0cykpOwoKT3RoZXIgZHJp dmVycyBoYXMgdGhpcyBhcyB0aGUgbGFzdCBzdGVtZW50IGluIHRoZWlyIGVuYWJsZSBmdW5jdGlv bi4KSSBkaWQgbm90IGNoZWNrIHdoeSwgYnV0IG1heWJlIHNvbWV0aGluZyB0byBpbnZlc3QgYSBm ZXcgbWludXRlcyBpbnRvLgpCZSBkaWZmZXJlbnQgb25seSBpZiB0aGVyZSBpcyBhIHJlYXNvbiB0 byBkbyBzby4KCj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJZHJtX21vZGVf cHJvYmVkX2FkZChwYW5lbC0+Y29ubmVjdG9yLCBtb2RlKTsKPiArCj4gKwlyZXR1cm4gMTsKPiAr fQo+ICsKPiArCj4gKyNpZmRlZiBDT05GSUdfUE0KPiArc3RhdGljIGludCByYWRfcGFuZWxfc3Vz cGVuZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gK3sKPiArCXN0cnVjdCByYWRfcGFuZWwgKnJhZCA9 IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+ICsKPiArCWlmICghcmFkLT5yZXNldCkKPiArCQlyZXR1 cm4gMDsKPiArCj4gKwlkZXZtX2dwaW9kX3B1dChkZXYsIHJhZC0+cmVzZXQpOwo+ICsJcmFkLT5y ZXNldCA9IE5VTEw7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgcmFk X3BhbmVsX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gK3sKPiArCXN0cnVjdCByYWRfcGFu ZWwgKnJhZCA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+ICsKPiArCWlmIChyYWQtPnJlc2V0KQo+ ICsJCXJldHVybiAwOwo+ICsKPiArCXJhZC0+cmVzZXQgPSBkZXZtX2dwaW9kX2dldChkZXYsICJy ZXNldCIsIEdQSU9EX09VVF9MT1cpOwo+ICsJaWYgKElTX0VSUihyYWQtPnJlc2V0KSkKPiArCQly YWQtPnJlc2V0ID0gTlVMTDsKPiArCj4gKwlyZXR1cm4gUFRSX0VSUl9PUl9aRVJPKHJhZC0+cmVz ZXQpOwo+ICt9Cj4gKwo+ICsjZW5kaWYKClVzZSBfX21heWJlX3VudXNlZCBmb3IgdGhlIHR3IGZ1 bmN0aW9ucyBhYm92ZS4KQW5kIGxvb3NlIHRoZSBpZmRlZi4uLgoKPiArCj4gK3N0YXRpYyBjb25z dCBzdHJ1Y3QgZGV2X3BtX29wcyByYWRfcG1fb3BzID0gewo+ICsJU0VUX1JVTlRJTUVfUE1fT1BT KHJhZF9wYW5lbF9zdXNwZW5kLCByYWRfcGFuZWxfcmVzdW1lLCBOVUxMKQo+ICsJU0VUX1NZU1RF TV9TTEVFUF9QTV9PUFMocmFkX3BhbmVsX3N1c3BlbmQsIHJhZF9wYW5lbF9yZXN1bWUpCj4gK307 Cj4gKwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCByYWRfb2ZfbWF0Y2hbXSA9 IHsKPiArCXsgLmNvbXBhdGlibGUgPSAicmF5ZGl1bSxybTY3MTkxIiwgfSwKPiArCXsgfQpXZSBv ZnRlbiwgYnV0IG5vdCBhbHdheXMsIHdyaXRlIHRoaXMgYXMgeyAvKiBzZW50aW5hbCAqLyB9LAoK PiArfTsKPiArTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgcmFkX29mX21hdGNoKTsKPiArCj4gK3N0 YXRpYyBzdHJ1Y3QgbWlwaV9kc2lfZHJpdmVyIHJhZF9wYW5lbF9kcml2ZXIgPSB7Cj4gKwkuZHJp dmVyID0gewo+ICsJCS5uYW1lID0gInBhbmVsLXJheWRpdW0tcm02NzE5MSIsCj4gKwkJLm9mX21h dGNoX3RhYmxlID0gcmFkX29mX21hdGNoLAo+ICsJCS5wbQk9ICZyYWRfcG1fb3BzLAo+ICsJfSwK PiArCS5wcm9iZSA9IHJhZF9wYW5lbF9wcm9iZSwKPiArCS5yZW1vdmUgPSByYWRfcGFuZWxfcmVt b3ZlLAo+ICsJLnNodXRkb3duID0gcmFkX3BhbmVsX3NodXRkb3duLAo+ICt9Owo+ICttb2R1bGVf bWlwaV9kc2lfZHJpdmVyKHJhZF9wYW5lbF9kcml2ZXIpOwo+ICsKPiArTU9EVUxFX0FVVEhPUigi Um9iZXJ0IENoaXJhcyA8cm9iZXJ0LmNoaXJhc0BueHAuY29tPiIpOwo+ICtNT0RVTEVfREVTQ1JJ UFRJT04oIkRSTSBEcml2ZXIgZm9yIFJheWRpdW0gUk02NzE5MSBNSVBJIERTSSBwYW5lbCIpOwo+ ICtNT0RVTEVfTElDRU5TRSgiR1BMIHYyIik7CgpXaXRoIHRoZSBhYm92ZSB0cml2aWFsaXRpZXMg Y29uc2lkZXJlZC9maXhlZDoKUmV2aWV3ZWQtYnk6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3Jn Lm9yZz4KCglTYW0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs