From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: tegra: Fix Jetson Nano GPU regulator
Date: Thu, 20 Jun 2019 11:19:05 +0200 [thread overview]
Message-ID: <20190620091905.GH26689@ulmo> (raw)
In-Reply-To: <20190620081702.17209-4-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On Thu, Jun 20, 2019 at 09:17:02AM +0100, Jon Hunter wrote:
> There are a few issues with the GPU regulator defined for Jetson Nano
> which are:
>
> 1. The GPU regulator is a PWM based regulator and not a fixed voltage
> regulator.
> 2. The output voltages for the GPU regulator are not correct.
> 3. The regulator enable ramp delay is too short for the regulator and
> needs to be increased. 2ms should be sufficient.
> 4. This is the same regulator used on Jetson TX1 and so make the ramp
> delay and settling time the same as Jetson TX1.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> .../boot/dts/nvidia/tegra210-p3450-0000.dts | 21 +++++++++++--------
> 1 file changed, 12 insertions(+), 9 deletions(-)
Applied to for-5.3/arm64/dt and added the following Fixes: line:
Fixes: 6772cd0eacc8 ("arm64: tegra: Add NVIDIA Jetson Nano Developer Kit support")
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-06-20 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 8:16 [PATCH 0/3] arm64: tegra: A few device-tree fixes Jon Hunter
2019-06-20 8:17 ` [PATCH 1/3] arm64: tegra: Fix AGIC register range Jon Hunter
2019-06-20 9:13 ` Thierry Reding
2019-06-20 8:17 ` [PATCH 2/3] arm64: tegra: Update Jetson TX1 GPU regulator timings Jon Hunter
2019-06-20 9:18 ` Thierry Reding
2019-06-20 8:17 ` [PATCH 3/3] arm64: tegra: Fix Jetson Nano GPU regulator Jon Hunter
2019-06-20 9:19 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620091905.GH26689@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).