From: Brian Masney <masneyb@onstation.org>
To: Luca Weiss <luca@z3ntu.xyz>
Cc: linux-arm-msm@vger.kernel.org,
~martijnbraam/pmos-upstream@lists.sr.ht,
Andy Gross <agross@kernel.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node
Date: Fri, 21 Jun 2019 21:43:02 -0400 [thread overview]
Message-ID: <20190622014302.GA20947@onstation.org> (raw)
In-Reply-To: <4607058.UzJteFJyig@g550jk>
On Fri, Jun 21, 2019 at 09:25:17PM +0200, Luca Weiss wrote:
> On Freitag, 21. Juni 2019 02:01:22 CEST you wrote:
> > I think that it makes sense to put this snippet in qcom-msm8974.dtsi
> > with a status of disabled, and then enable it in
> > qcom-msm8974-fairphone-fp2.dts like so:
> >
> > imem@fe805000 {
> > status = "ok";
> > };
>
> Do you want me to put the whole node in the the dtsi file? Even though these
> values are the same, there are also custom vendor-specified values for specific
> phones.
mach-msm in the downstream hammerhead sources has those addresses:
https://github.com/AICP/kernel_lge_hammerhead/blob/n7.1/arch/arm/mach-msm/restart.c#L271
This lead me to think that it applies to other msm8974-based systems as
well.
I tried your device tree snippet on the Nexus 5 and it reboots the phone
for me.
/ # ./reboot-mode normal
[ 85.088556] reboot: Restarting system with command 'normal'
The recovery and bootloader modes reboot the phone but into normal mode.
Oddly, the bootloader shows different power on reasons after the
"welcome to hammerhead bootloader" message.
normal = [10] Power on reason 20001
recovery = [10] Power on reason 1
bootloader = [10] Power on reason 20001
> On the Linux kernel side, it has bootloader (0x77665500), recovery
> (0x77665502), rtc (0x77665503), oem-* (0x6f656d00 | somevalue), edl (some
> other addresses), and the else statements writes the 0x77665501 value in my
> patch.
The downstream hammerhead sources have the oem-*, and emergency download
modes (edl) listed as well.
I'm not sure on your other questions.
Brian
next prev parent reply other threads:[~2019-06-22 1:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 22:58 [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node Luca Weiss
2019-06-21 0:01 ` Brian Masney
2019-06-21 19:25 ` Luca Weiss
2019-06-22 1:43 ` Brian Masney [this message]
2019-07-13 11:26 ` Luca Weiss
2019-07-13 14:31 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190622014302.GA20947@onstation.org \
--to=masneyb@onstation.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=~martijnbraam/pmos-upstream@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).