From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux admin Subject: Re: [PATCH v7 4/7] arm: Use common cpu_topology structure and functions. Date: Mon, 24 Jun 2019 16:30:33 +0100 Message-ID: <20190624153033.3jpdd7vsekdiltmb@shell.armlinux.org.uk> References: <20190617185920.29581-1-atish.patra@wdc.com> <20190617185920.29581-5-atish.patra@wdc.com> <20190619121057.GE1360@e107155-lin> <20190624150658.GA1623@e107155-lin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190624150658.GA1623@e107155-lin> Sender: linux-kernel-owner@vger.kernel.org To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, Albert Ou , Anup Patel , Catalin Marinas , "David S. Miller" , devicetree@vger.kernel.org, Greg Kroah-Hartman , Ingo Molnar , Jonathan Cameron , Linus Walleij , linux-riscv@lists.infradead.org, Mark Rutland , Mauro Carvalho Chehab , Morten Rasmussen , Otto Sabart , Palmer Dabbelt , Paul Walmsley , "Peter Zijlstra (Intel)" , "Rafael J. Wysocki" List-Id: devicetree@vger.kernel.org On Mon, Jun 24, 2019 at 04:06:58PM +0100, Sudeep Holla wrote: > On Wed, Jun 19, 2019 at 01:10:57PM +0100, Sudeep Holla wrote: > > Hi Russell, > > > > On Mon, Jun 17, 2019 at 11:59:17AM -0700, Atish Patra wrote: > > > Currently, ARM32 and ARM64 uses different data structures to represent > > > their cpu topologies. Since, we are moving the ARM64 topology to common > > > code to be used by other architectures, we can reuse that for ARM32 as > > > well. > > > > > > Take this opprtunity to remove the redundant functions from ARM32 and > > > reuse the common code instead. > > > > > > To: Russell King > > > Signed-off-by: Atish Patra > > > Tested-by: Sudeep Holla (on TC2) > > > Reviewed-by : Sudeep Holla > > > > > > --- > > > Hi Russell, > > > Can we get a ACK for this patch ? We are hoping that the entire > > > series can be merged at one go. > > > > It would be nice to get this in for v5.3 as it's almost there. > > Are you fine with these changes ? > > > > Do you have any objections with this patch ? We plan to merge through > RISC-V tree, please let us know. It has been acked-by all the other > maintainers. I have no interest in the CPU topology code; as far as I know I have no systems that are able to exercise this code in any way. Therefore, I don't know this code, I have no way to test it, and so it is not appropriate for me to ack patches for it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up