From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt) Date: Tue, 25 Jun 2019 11:55:33 +0200 Message-ID: <20190625095533.GC1688@kunai> References: <1561449642-26956-1-git-send-email-eugen.hristev@microchip.com> <1561449642-26956-7-git-send-email-eugen.hristev@microchip.com> <4e81d3c9-25f3-ca6e-f2d5-17fad5905bb8@axentia.se> <84628b5e-bea7-7d91-f790-f3a2650040fa@microchip.com> <20190625093156.GF5690@piout.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PuGuTyElPB9bOcsM" Return-path: Content-Disposition: inline In-Reply-To: <20190625093156.GF5690@piout.net> Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Belloni Cc: Eugen.Hristev@microchip.com, peda@axentia.se, robh+dt@kernel.org, mark.rutland@arm.com, Nicolas.Ferre@microchip.com, Ludovic.Desroches@microchip.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Pierre-Yves MORDRET List-Id: devicetree@vger.kernel.org --PuGuTyElPB9bOcsM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 25, 2019 at 11:31:56AM +0200, Alexandre Belloni wrote: > On 25/06/2019 09:14:13+0000, Eugen.Hristev@microchip.com wrote: > > > Perhaps > > >=20 > > > microchip,digital-filter; > > > microchip,analog-filter; > > >=20 > > > ? > >=20 > > Hi Peter, > >=20 > > Thanks for reviewing. The name of the property does not matter much to= =20 > > me, and we have properties prefixed with vendor, and some are not. > >=20 > > @Alexandre Belloni: which name you think it's best ? > >=20 >=20 > I'm not sure, it depends on whether Wolfram thinks it is generic enough > to be used without a vendor prefix. I could imagine that we design a generic property for filters. The ones above make me wonder, though, because they are bool. I'd think you can configure the filters in some way, too? I never used such filtering, so I am unaware of the parameters needed / suitable. Quick grepping through I2C master drivers reveals that i2c-stm32f7.c also handles filters, but only with default values. Maybe DT configuration would be benefitial to that driver, too? Adding some people to CC. --PuGuTyElPB9bOcsM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl0R75EACgkQFA3kzBSg KbaFyA//UefpasMtRS97YQqN/2m6N9Xgl7LiXTof1v53GW/mee1Y8ce675X8tAHL H2Hcvak1eeDIBiN+FPopoUSZ3EhxO3jsMeuR4cAXAKgbFS9lngHGyQcYWd8EZG3p lxcbnahpnUOBnvFKHet1j84f3RAkk8tksxEc7sFaV5puN3dReSBA5e++trJz73yk oUjx+42R9Zytrt27IsH+Vy86znzzuDboc+ngLwl+deTGG3E56xLAUNX4U5eGLJiJ jL7Ot0GUBIw+iHI610z+HrzuKREIQGY3XkGowq+ZU6RxgSnpdf0faRp8EqfRaJdb i0379EM5C0Hb4O0l7RLMmlNPWaIGPVhoh7Hr2cBSEXMmL4Fr8uBWNlpkKU1aFM4v 4mq4KBULWYfihJ2CfFqWyKOLzY4320whOiHcq0O+81nYSrRoXCEpYyxHMLpfTicW YSysulIyWNbAv+j+Cns7y6SRE/Pm6HBaWsHuP8gqKha0+wjmAs+eE6zwZ4RiUYez tSqP31BTOQw7UG26/FOX+N/fAtBGQP2NcBePPSAmMBLTGAiAXWnEIZv/x9MO9qJ1 kVEs2wtgeyX93qxwedyL9ueTa/d5HbmMpYDN0R3PFwpqGyC+qkyNlatWd/DJutwP oXKFHwEdabgjoSwYIaIfHkP4gxF/5BJp3F0H+vR/n+sDlQoaWp4= =qB/9 -----END PGP SIGNATURE----- --PuGuTyElPB9bOcsM--