From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v10 1/6] mfd: rk808: remove the id_table Date: Wed, 26 Jun 2019 12:53:58 +0100 Message-ID: <20190626115358.GS21119@dell> References: <20190621103258.8154-1-tony.xie@rock-chips.com> <20190621103258.8154-2-tony.xie@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190621103258.8154-2-tony.xie@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org To: Tony Xie Cc: heiko@sntech.de, broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, chenjh@rock-chips.com, xsf@rock-chips.com, zhangqing@rock-chips.com, huangtao@rock-chips.com List-Id: devicetree@vger.kernel.org On Fri, 21 Jun 2019, Tony Xie wrote: > Remove the id_table because it's not used. > > Signed-off-by: Tony Xie > --- > drivers/mfd/rk808.c | 9 --------- > 1 file changed, 9 deletions(-) Also, this patch already appears to be applied. Once patches are taken from the set, you should avoid resending them. > diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c > index 216fbf6adec9..94377782d208 100644 > --- a/drivers/mfd/rk808.c > +++ b/drivers/mfd/rk808.c > @@ -568,14 +568,6 @@ static int rk808_remove(struct i2c_client *client) > return 0; > } > > -static const struct i2c_device_id rk808_ids[] = { > - { "rk805" }, > - { "rk808" }, > - { "rk818" }, > - { }, > -}; > -MODULE_DEVICE_TABLE(i2c, rk808_ids); > - > static struct i2c_driver rk808_i2c_driver = { > .driver = { > .name = "rk808", > @@ -583,7 +575,6 @@ static struct i2c_driver rk808_i2c_driver = { > }, > .probe = rk808_probe, > .remove = rk808_remove, > - .id_table = rk808_ids, > }; > > module_i2c_driver(rk808_i2c_driver); -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog