devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: masonccyang@mxic.com.tw
Cc: anders.roxell@linaro.org, bbrezillon@kernel.org,
	broonie@kernel.org, christophe.kerello@st.com,
	computersforpeace@gmail.com, devicetree@vger.kernel.org,
	dwmw2@infradead.org, jianxin.pan@amlogic.com,
	juliensu@mxic.com.tw, lee.jones@linaro.org,
	liang.yang@amlogic.com, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, marek.vasut@gmail.com,
	paul@crapouillou.net, paul.burton@mips.com, richard@nod.at,
	stefan@agner.ch, vigneshr@ti.com
Subject: Re: [PATCH v4 1/2] mtd: rawnand: Add Macronix Raw NAND controller
Date: Fri, 28 Jun 2019 10:44:23 +0200	[thread overview]
Message-ID: <20190628104423.5eb3058a@xps13> (raw)
In-Reply-To: <OF2EDB7089.FAD92F61-ON48258427.002D122A-48258427.002ECEF3@mxic.com.tw>

Hi Mason,

masonccyang@mxic.com.tw wrote on Fri, 28 Jun 2019 16:31:16 +0800:

> Hi Miquel,
> 
> > >   
> > > > > Add a driver for Macronix raw NAND controller.   
> > > > 
> > > > Could you pass userspace major MTD tests and can you   
> attach/mount/edit
> > > > a UBI/UBIFS storage?   
> > > 
> > > mtd_debug passed and using dd utility to read and write 
> > > with md5sum checking passed.  
> > 
> > Please don't use dd, use nanddump/nandwrite/flasherase/nandbiterrs and
> > run the other tests from the mtd-utils test suite (available in
> > Buildroot for instance).
> >   
> 
> Got it.
> 
> But may I know why 'dd' utility is not preferences ?
> I generate a random data file and write to Flash by
> using dd with bs=page size and read data back from Flash.
> Checking data by md5sum.

Because dd works on block devices. MTD devices are way different. You
cannot write to OOB with dd. You cannot erase before write with dd. And
dd does not know about bad blocks. Please simply avoid using dd.

> The write and read testing data size is easily adjustable.

So are the MTD utils.

Thanks,
Miquèl

  reply	other threads:[~2019-06-28  8:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25  6:10 [PATCH v4 0/2] Add Macronix Raw NAND controller driver Mason Yang
2019-06-25  6:10 ` [PATCH v4 1/2] mtd: rawnand: Add Macronix Raw NAND controller Mason Yang
2019-06-27 17:36   ` Miquel Raynal
2019-06-28  6:01     ` masonccyang
2019-06-28  7:18       ` Miquel Raynal
2019-06-28  8:31         ` masonccyang
2019-06-28  8:44           ` Miquel Raynal [this message]
2019-07-03  3:03     ` masonccyang
2019-06-25  6:10 ` [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings Mason Yang
2019-06-27 17:26   ` Miquel Raynal
2019-06-28  6:48     ` masonccyang
2019-06-28  7:42       ` Miquel Raynal
2019-06-28  9:09         ` masonccyang
2019-06-28  9:12           ` Miquel Raynal
2019-06-28  9:23             ` masonccyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628104423.5eb3058a@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=anders.roxell@linaro.org \
    --cc=bbrezillon@kernel.org \
    --cc=broonie@kernel.org \
    --cc=christophe.kerello@st.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=jianxin.pan@amlogic.com \
    --cc=juliensu@mxic.com.tw \
    --cc=lee.jones@linaro.org \
    --cc=liang.yang@amlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=masonccyang@mxic.com.tw \
    --cc=paul.burton@mips.com \
    --cc=paul@crapouillou.net \
    --cc=richard@nod.at \
    --cc=stefan@agner.ch \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).