Devicetree
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
	"Donggeun Kim" <dg77.kim@samsung.com>,
	"MyungJoo Ham" <myungjoo.ham@samsung.com>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] extcon: Add fsa9480 extcon driver
Date: Fri, 28 Jun 2019 14:37:38 +0200	[thread overview]
Message-ID: <20190628123738.GA25339@kroah.com> (raw)
In-Reply-To: <CACRpkdYD7Z7XX9wXFtBehJG_4NCt=m_MNsR5cESPRnO3tomKmQ@mail.gmail.com>

On Fri, Jun 28, 2019 at 11:28:11AM +0100, Linus Walleij wrote:
> On Fri, Jun 21, 2019 at 12:14 PM Paweł Chmiel
> <pawel.mikolaj.chmiel@gmail.com> wrote:
> 
> > This small patchset adds support for Fairchild Semiconductor FSA9480
> > microUSB switch.
> >
> > It has been tested on Samsung Galaxy S and Samsung Fascinate 4G,
> > but it can be found also on other Samsung Aries (s5pv210) based devices.
> >
> > Tomasz Figa (2):
> >   dt-bindings: extcon: Add support for fsa9480 switch
> >   extcon: Add fsa9480 extcon driver
> 
> This is surely an important driver since almost all elder Samsung
> mobiles use this kind of switch. So
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> This driver I see is already sent to Greg for inclusion in the next kernel.
> I just wonder if you guys are even aware of this driver for the same
> hardware added by Donggeun Kim in 2011:
> drivers/misc/fsa9480.c
> 
> That said I am all for pulling in this new driver because it is surely
> better and supports device tree.
> 
> But can we please also send Greg a patch to delete the old driver
> so we don't have two of them now?
> 
> The old driver have no in-tree users so it can be deleted without
> side effects. Out-of-tree users can certainly adapt to the new
> extcon driver.
> 
> If you want I can send a deletion patch for the misc driver?

Please, I'll gladly take a patch that deletes code :)

thanks,

greg k-h

  reply	other threads:[~2019-06-28 12:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190621111402epcas4p2f65fb1b6d3e83bd69bd129b27c90d295@epcas4p2.samsung.com>
2019-06-21 11:13 ` [PATCH v2 0/2] extcon: Add fsa9480 extcon driver Paweł Chmiel
2019-06-21 11:13   ` [PATCH v2 1/2] dt-bindings: extcon: Add support for fsa9480 switch Paweł Chmiel
2019-06-21 11:13   ` [PATCH v2 2/2] extcon: Add fsa9480 extcon driver Paweł Chmiel
2019-06-22 12:44   ` [PATCH v2 0/2] " Chanwoo Choi
2019-06-23 23:56   ` Chanwoo Choi
2019-06-28 10:28   ` Linus Walleij
2019-06-28 12:37     ` Greg KH [this message]
2019-06-28 12:45       ` Paweł Chmiel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628123738.GA25339@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dg77.kim@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=pawel.mikolaj.chmiel@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox