From: Govind Singh <govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Govind Singh <govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: [PATCH 2/3] ath10k: Move regulator config to driver private data
Date: Wed, 3 Jul 2019 09:27:10 +0530 [thread overview]
Message-ID: <20190703035711.25592-3-govinds@codeaurora.org> (raw)
In-Reply-To: <20190703035711.25592-1-govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
WCN3990 Regulator config is varying b/w different MSM platforms.
In order to have scalable config, move regulator config to driver
private data.
Signed-off-by: Govind Singh <govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
---
drivers/net/wireless/ath/ath10k/snoc.c | 38 +++++++++++++++++++++-----
drivers/net/wireless/ath/ath10k/snoc.h | 23 +++++++++-------
2 files changed, 44 insertions(+), 17 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
index ca1186ec4129..bd7d97924fe0 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -36,13 +36,20 @@ static char *const ce_name[] = {
"WLAN_CE_11",
};
-static struct ath10k_vreg_info vreg_cfg[] = {
+static struct ath10k_vreg_info sdm845_reg_cfg[] = {
{NULL, "vdd-0.8-cx-mx", 800000, 850000, 0, 0, false},
{NULL, "vdd-1.8-xo", 1800000, 1850000, 0, 0, false},
{NULL, "vdd-1.3-rfa", 1300000, 1350000, 0, 0, false},
{NULL, "vdd-3.3-ch0", 3300000, 3350000, 0, 0, false},
};
+static struct ath10k_vreg_info qcs40x_reg_cfg[] = {
+ {NULL, "vdd-0.8-cx-mx", 1224000, 1224000, 0, 0, false},
+ {NULL, "vdd-1.8-xo", 1800000, 1850000, 0, 0, false},
+ {NULL, "vdd-1.3-rfa", 1300000, 1350000, 0, 0, false},
+ {NULL, "vdd-3.3-ch0", 3300000, 3350000, 0, 0, false},
+};
+
static struct ath10k_clk_info clk_cfg[] = {
{NULL, "cxo_ref_clk_pin", 0, false},
};
@@ -54,10 +61,20 @@ static void ath10k_snoc_htt_rx_cb(struct ath10k_ce_pipe *ce_state);
static void ath10k_snoc_htt_htc_rx_cb(struct ath10k_ce_pipe *ce_state);
static void ath10k_snoc_pktlog_rx_cb(struct ath10k_ce_pipe *ce_state);
-static const struct ath10k_snoc_drv_priv drv_priv = {
+static const struct ath10k_snoc_drv_priv sdm845_wcn39xx_drv_priv = {
+ .hw_rev = ATH10K_HW_WCN3990,
+ .dma_mask = DMA_BIT_MASK(35),
+ .msa_size = 0x100000,
+ .vreg_cfg = sdm845_reg_cfg,
+ .vreg_count = ARRAY_SIZE(sdm845_reg_cfg),
+};
+
+static const struct ath10k_snoc_drv_priv qcs40x_wcn39xx_drv_priv = {
.hw_rev = ATH10K_HW_WCN3990,
.dma_mask = DMA_BIT_MASK(35),
.msa_size = 0x100000,
+ .vreg_cfg = qcs40x_reg_cfg,
+ .vreg_count = ARRAY_SIZE(qcs40x_reg_cfg),
};
#define WCN3990_SRC_WR_IDX_OFFSET 0x3C
@@ -1465,7 +1482,7 @@ static int ath10k_snoc_vreg_on(struct ath10k *ar)
int ret = 0;
int i;
- for (i = 0; i < ARRAY_SIZE(vreg_cfg); i++) {
+ for (i = 0; i < ar_snoc->vreg_count; i++) {
vreg_info = &ar_snoc->vreg[i];
if (!vreg_info->reg)
@@ -1498,7 +1515,7 @@ static int ath10k_snoc_vreg_off(struct ath10k *ar)
int ret = 0;
int i;
- for (i = ARRAY_SIZE(vreg_cfg) - 1; i >= 0; i--) {
+ for (i = ar_snoc->vreg_count - 1; i >= 0; i--) {
vreg_info = &ar_snoc->vreg[i];
if (!vreg_info->reg)
@@ -1616,7 +1633,13 @@ static int ath10k_hw_power_off(struct ath10k *ar)
static const struct of_device_id ath10k_snoc_dt_match[] = {
{ .compatible = "qcom,wcn3990-wifi",
- .data = &drv_priv,
+ .data = &sdm845_wcn39xx_drv_priv,
+ },
+ { .compatible = "qcom,sdm845-wcn39xx-wifi",
+ .data = &sdm845_wcn39xx_drv_priv,
+ },
+ { .compatible = "qcom,qcs40x-wcn39xx-wifi",
+ .data = &qcs40x_wcn39xx_drv_priv,
},
{ }
};
@@ -1680,8 +1703,9 @@ static int ath10k_snoc_probe(struct platform_device *pdev)
goto err_release_resource;
}
- ar_snoc->vreg = vreg_cfg;
- for (i = 0; i < ARRAY_SIZE(vreg_cfg); i++) {
+ ar_snoc->vreg = drv_data->vreg_cfg;
+ ar_snoc->vreg_count = drv_data->vreg_count;
+ for (i = 0; i < ar_snoc->vreg_count; i++) {
ret = ath10k_get_vreg_info(ar, dev, &ar_snoc->vreg[i]);
if (ret)
goto err_free_irq;
diff --git a/drivers/net/wireless/ath/ath10k/snoc.h b/drivers/net/wireless/ath/ath10k/snoc.h
index d62f53501fbb..0bdada11985c 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.h
+++ b/drivers/net/wireless/ath/ath10k/snoc.h
@@ -10,10 +10,22 @@
#include "ce.h"
#include "qmi.h"
+struct ath10k_vreg_info {
+ struct regulator *reg;
+ const char *name;
+ u32 min_v;
+ u32 max_v;
+ u32 load_ua;
+ unsigned long settle_delay;
+ bool required;
+};
+
struct ath10k_snoc_drv_priv {
enum ath10k_hw_rev hw_rev;
u64 dma_mask;
u32 msa_size;
+ struct ath10k_vreg_info *vreg_cfg;
+ u8 vreg_count;
};
struct snoc_state {
@@ -42,16 +54,6 @@ struct ath10k_snoc_ce_irq {
u32 irq_line;
};
-struct ath10k_vreg_info {
- struct regulator *reg;
- const char *name;
- u32 min_v;
- u32 max_v;
- u32 load_ua;
- unsigned long settle_delay;
- bool required;
-};
next prev parent reply other threads:[~2019-07-03 3:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 3:57 [PATCH 0/3] Move voltage regulator config to driver private data Govind Singh
[not found] ` <20190703035711.25592-1-govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2019-07-03 3:57 ` [PATCH 1/3] dt: bindings: update compatible dt properties for WCN3990 wifi node Govind Singh
[not found] ` <20190703035711.25592-2-govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2019-07-22 23:40 ` Rob Herring
2019-07-03 3:57 ` Govind Singh [this message]
[not found] ` <20190703035711.25592-3-govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2019-07-22 23:57 ` [PATCH 2/3] ath10k: Move regulator config to driver private data Bjorn Andersson
2019-07-23 6:43 ` Govind Singh
2019-07-03 3:57 ` [PATCH 3/3] arm64: dts: qcom: qcs404: Modify wifi dt node for SDM845/QCS404 devices Govind Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703035711.25592-3-govinds@codeaurora.org \
--to=govinds-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).