* [PATCH arm64/dts 1/1] arm64: dts: imx8qxp: add lpuart baud clock
@ 2019-07-04 10:04 fugang.duan
2019-07-22 6:46 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: fugang.duan @ 2019-07-04 10:04 UTC (permalink / raw)
To: festevam, shawnguo
Cc: devicetree, daniel.baluta, fugang.duan, linux-arm-kernel
From: Fugang Duan <fugang.duan@nxp.com>
Add imx8qxp lpuart baud clock.
Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 23 +++++++++++++++--------
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
index 05fa0b7..4402b2e 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -30,6 +30,9 @@
mmc2 = &usdhc3;
mu1 = &lsio_mu1;
serial0 = &adma_lpuart0;
+ serial1 = &adma_lpuart1;
+ serial2 = &adma_lpuart2;
+ serial3 = &adma_lpuart3;
};
cpus {
@@ -209,8 +212,9 @@
reg = <0x5a060000 0x1000>;
interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
interrupt-parent = <&gic>;
- clocks = <&adma_lpcg IMX_ADMA_LPCG_UART0_BAUD_CLK>;
- clock-names = "ipg";
+ clocks = <&adma_lpcg IMX_ADMA_LPCG_UART0_IPG_CLK>,
+ <&adma_lpcg IMX_ADMA_LPCG_UART0_BAUD_CLK>;
+ clock-names = "ipg", "baud";
power-domains = <&pd IMX_SC_R_UART_0>;
status = "disabled";
};
@@ -220,8 +224,9 @@
reg = <0x5a070000 0x1000>;
interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
interrupt-parent = <&gic>;
- clocks = <&adma_lpcg IMX_ADMA_LPCG_UART1_BAUD_CLK>;
- clock-names = "ipg";
+ clocks = <&adma_lpcg IMX_ADMA_LPCG_UART1_IPG_CLK>,
+ <&adma_lpcg IMX_ADMA_LPCG_UART1_BAUD_CLK>;
+ clock-names = "ipg", "baud";
power-domains = <&pd IMX_SC_R_UART_1>;
status = "disabled";
};
@@ -231,8 +236,9 @@
reg = <0x5a080000 0x1000>;
interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
interrupt-parent = <&gic>;
- clocks = <&adma_lpcg IMX_ADMA_LPCG_UART2_BAUD_CLK>;
- clock-names = "ipg";
+ clocks = <&adma_lpcg IMX_ADMA_LPCG_UART2_IPG_CLK>,
+ <&adma_lpcg IMX_ADMA_LPCG_UART2_BAUD_CLK>;
+ clock-names = "ipg", "baud";
power-domains = <&pd IMX_SC_R_UART_2>;
status = "disabled";
};
@@ -242,8 +248,9 @@
reg = <0x5a090000 0x1000>;
interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH>;
interrupt-parent = <&gic>;
- clocks = <&adma_lpcg IMX_ADMA_LPCG_UART3_BAUD_CLK>;
- clock-names = "ipg";
+ clocks = <&adma_lpcg IMX_ADMA_LPCG_UART3_IPG_CLK>,
+ <&adma_lpcg IMX_ADMA_LPCG_UART3_BAUD_CLK>;
+ clock-names = "ipg", "baud";
power-domains = <&pd IMX_SC_R_UART_3>;
status = "disabled";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH arm64/dts 1/1] arm64: dts: imx8qxp: add lpuart baud clock
2019-07-04 10:04 [PATCH arm64/dts 1/1] arm64: dts: imx8qxp: add lpuart baud clock fugang.duan
@ 2019-07-22 6:46 ` Shawn Guo
2019-07-22 6:52 ` [EXT] " Andy Duan
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2019-07-22 6:46 UTC (permalink / raw)
To: fugang.duan; +Cc: devicetree, daniel.baluta, festevam, linux-arm-kernel
On Thu, Jul 04, 2019 at 06:04:43PM +0800, fugang.duan@nxp.com wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
>
> Add imx8qxp lpuart baud clock.
>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 05fa0b7..4402b2e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -30,6 +30,9 @@
> mmc2 = &usdhc3;
> mu1 = &lsio_mu1;
> serial0 = &adma_lpuart0;
> + serial1 = &adma_lpuart1;
> + serial2 = &adma_lpuart2;
> + serial3 = &adma_lpuart3;
This is not about adding baud clock, right? Please either mention the
change in the commit log, or have it as a separate patch.
Shawn
> };
>
> cpus {
> @@ -209,8 +212,9 @@
> reg = <0x5a060000 0x1000>;
> interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> - clocks = <&adma_lpcg IMX_ADMA_LPCG_UART0_BAUD_CLK>;
> - clock-names = "ipg";
> + clocks = <&adma_lpcg IMX_ADMA_LPCG_UART0_IPG_CLK>,
> + <&adma_lpcg IMX_ADMA_LPCG_UART0_BAUD_CLK>;
> + clock-names = "ipg", "baud";
> power-domains = <&pd IMX_SC_R_UART_0>;
> status = "disabled";
> };
> @@ -220,8 +224,9 @@
> reg = <0x5a070000 0x1000>;
> interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> - clocks = <&adma_lpcg IMX_ADMA_LPCG_UART1_BAUD_CLK>;
> - clock-names = "ipg";
> + clocks = <&adma_lpcg IMX_ADMA_LPCG_UART1_IPG_CLK>,
> + <&adma_lpcg IMX_ADMA_LPCG_UART1_BAUD_CLK>;
> + clock-names = "ipg", "baud";
> power-domains = <&pd IMX_SC_R_UART_1>;
> status = "disabled";
> };
> @@ -231,8 +236,9 @@
> reg = <0x5a080000 0x1000>;
> interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> - clocks = <&adma_lpcg IMX_ADMA_LPCG_UART2_BAUD_CLK>;
> - clock-names = "ipg";
> + clocks = <&adma_lpcg IMX_ADMA_LPCG_UART2_IPG_CLK>,
> + <&adma_lpcg IMX_ADMA_LPCG_UART2_BAUD_CLK>;
> + clock-names = "ipg", "baud";
> power-domains = <&pd IMX_SC_R_UART_2>;
> status = "disabled";
> };
> @@ -242,8 +248,9 @@
> reg = <0x5a090000 0x1000>;
> interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> - clocks = <&adma_lpcg IMX_ADMA_LPCG_UART3_BAUD_CLK>;
> - clock-names = "ipg";
> + clocks = <&adma_lpcg IMX_ADMA_LPCG_UART3_IPG_CLK>,
> + <&adma_lpcg IMX_ADMA_LPCG_UART3_BAUD_CLK>;
> + clock-names = "ipg", "baud";
> power-domains = <&pd IMX_SC_R_UART_3>;
> status = "disabled";
> };
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [EXT] Re: [PATCH arm64/dts 1/1] arm64: dts: imx8qxp: add lpuart baud clock
2019-07-22 6:46 ` Shawn Guo
@ 2019-07-22 6:52 ` Andy Duan
0 siblings, 0 replies; 3+ messages in thread
From: Andy Duan @ 2019-07-22 6:52 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree@vger.kernel.org, daniel.baluta@gmail.com,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
From: Shawn Guo <shawnguo@kernel.org> Sent: Monday, July 22, 2019 2:47 PM
> On Thu, Jul 04, 2019 at 06:04:43PM +0800, fugang.duan@nxp.com wrote:
> > From: Fugang Duan <fugang.duan@nxp.com>
> >
> > Add imx8qxp lpuart baud clock.
> >
> > Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 23
> > +++++++++++++++--------
> > 1 file changed, 15 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > index 05fa0b7..4402b2e 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > @@ -30,6 +30,9 @@
> > mmc2 = &usdhc3;
> > mu1 = &lsio_mu1;
> > serial0 = &adma_lpuart0;
> > + serial1 = &adma_lpuart1;
> > + serial2 = &adma_lpuart2;
> > + serial3 = &adma_lpuart3;
>
> This is not about adding baud clock, right? Please either mention the change
> in the commit log, or have it as a separate patch.
>
> Shawn
Thanks for your review.
I will send v2 to separate the patch.
>
> > };
> >
> > cpus {
> > @@ -209,8 +212,9 @@
> > reg = <0x5a060000 0x1000>;
> > interrupts = <GIC_SPI 225
> IRQ_TYPE_LEVEL_HIGH>;
> > interrupt-parent = <&gic>;
> > - clocks = <&adma_lpcg
> IMX_ADMA_LPCG_UART0_BAUD_CLK>;
> > - clock-names = "ipg";
> > + clocks = <&adma_lpcg
> IMX_ADMA_LPCG_UART0_IPG_CLK>,
> > + <&adma_lpcg
> IMX_ADMA_LPCG_UART0_BAUD_CLK>;
> > + clock-names = "ipg", "baud";
> > power-domains = <&pd IMX_SC_R_UART_0>;
> > status = "disabled";
> > };
> > @@ -220,8 +224,9 @@
> > reg = <0x5a070000 0x1000>;
> > interrupts = <GIC_SPI 226
> IRQ_TYPE_LEVEL_HIGH>;
> > interrupt-parent = <&gic>;
> > - clocks = <&adma_lpcg
> IMX_ADMA_LPCG_UART1_BAUD_CLK>;
> > - clock-names = "ipg";
> > + clocks = <&adma_lpcg
> IMX_ADMA_LPCG_UART1_IPG_CLK>,
> > + <&adma_lpcg
> IMX_ADMA_LPCG_UART1_BAUD_CLK>;
> > + clock-names = "ipg", "baud";
> > power-domains = <&pd IMX_SC_R_UART_1>;
> > status = "disabled";
> > };
> > @@ -231,8 +236,9 @@
> > reg = <0x5a080000 0x1000>;
> > interrupts = <GIC_SPI 227
> IRQ_TYPE_LEVEL_HIGH>;
> > interrupt-parent = <&gic>;
> > - clocks = <&adma_lpcg
> IMX_ADMA_LPCG_UART2_BAUD_CLK>;
> > - clock-names = "ipg";
> > + clocks = <&adma_lpcg
> IMX_ADMA_LPCG_UART2_IPG_CLK>,
> > + <&adma_lpcg
> IMX_ADMA_LPCG_UART2_BAUD_CLK>;
> > + clock-names = "ipg", "baud";
> > power-domains = <&pd IMX_SC_R_UART_2>;
> > status = "disabled";
> > };
> > @@ -242,8 +248,9 @@
> > reg = <0x5a090000 0x1000>;
> > interrupts = <GIC_SPI 228
> IRQ_TYPE_LEVEL_HIGH>;
> > interrupt-parent = <&gic>;
> > - clocks = <&adma_lpcg
> IMX_ADMA_LPCG_UART3_BAUD_CLK>;
> > - clock-names = "ipg";
> > + clocks = <&adma_lpcg
> IMX_ADMA_LPCG_UART3_IPG_CLK>,
> > + <&adma_lpcg
> IMX_ADMA_LPCG_UART3_BAUD_CLK>;
> > + clock-names = "ipg", "baud";
> > power-domains = <&pd IMX_SC_R_UART_3>;
> > status = "disabled";
> > };
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-22 6:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-04 10:04 [PATCH arm64/dts 1/1] arm64: dts: imx8qxp: add lpuart baud clock fugang.duan
2019-07-22 6:46 ` Shawn Guo
2019-07-22 6:52 ` [EXT] " Andy Duan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).