devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v3 1/7] dt-bindings: net: Add bindings for Realtek PHYs
Date: Mon, 8 Jul 2019 21:46:15 +0200	[thread overview]
Message-ID: <20190708194615.GH9027@lunn.ch> (raw)
In-Reply-To: <20190708192459.187984-2-mka@chromium.org>

On Mon, Jul 08, 2019 at 12:24:53PM -0700, Matthias Kaehlcke wrote:
> Add the 'realtek,eee-led-mode-disable' property to disable EEE
> LED mode on Realtek PHYs that support it.
> 
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> TODO: adapt PHY core to deal with optional compatible strings

Yes. Does this even work at the moment? I would expect
of_mdiobus_child_is_phy() to return false, indicating the device is
not actually a PHY.

    Andrew

  reply	other threads:[~2019-07-08 19:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08 19:24 [PATCH v3 0/7] net: phy: realtek: Enable configuration of RTL8211E LEDs and SSC Matthias Kaehlcke
2019-07-08 19:24 ` [PATCH v3 1/7] dt-bindings: net: Add bindings for Realtek PHYs Matthias Kaehlcke
2019-07-08 19:46   ` Andrew Lunn [this message]
2019-07-08 20:01     ` Matthias Kaehlcke
2019-07-08 21:13       ` Andrew Lunn
2019-07-08 19:24 ` [PATCH v3 2/7] net: phy: realtek: Allow disabling RTL8211E EEE LED mode Matthias Kaehlcke
2019-07-08 19:24 ` [PATCH v3 3/7] dt-bindings: net: realtek: Add property to enable SSC Matthias Kaehlcke
2019-07-08 19:24 ` [PATCH v3 4/7] net: phy: realtek: Add helpers for accessing RTL8211E extension pages Matthias Kaehlcke
2019-07-08 19:24 ` [PATCH v3 5/7] net: phy: realtek: Support SSC for the RTL8211E Matthias Kaehlcke
2019-07-08 19:24 ` [PATCH v3 6/7] dt-bindings: net: realtek: Add property to configure LED mode Matthias Kaehlcke
2019-07-08 19:48   ` Andrew Lunn
2019-07-08 20:07     ` Matthias Kaehlcke
2019-07-08 19:24 ` [PATCH v3 7/7] net: phy: realtek: configure RTL8211E LEDs Matthias Kaehlcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190708194615.GH9027@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mka@chromium.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).