From: Saravana Kannan <saravanak@google.com>
To: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Cc: Saravana Kannan <saravanak@google.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
David Collins <collinsd@codeaurora.org>,
kernel-team@android.com
Subject: [PATCH v4 0/8] Solve postboot supplier cleanup and optimize probe ordering
Date: Mon, 8 Jul 2019 15:56:16 -0700 [thread overview]
Message-ID: <20190708225624.119973-1-saravanak@google.com> (raw)
Add device-links to track functional dependencies between devices
after they are created (but before they are probed) by looking at
their common DT bindings like clocks, interconnects, etc.
Having functional dependencies automatically added before the devices
are probed, provides the following benefits:
- Optimizes device probe order and avoids the useless work of
attempting probes of devices that will not probe successfully
(because their suppliers aren't present or haven't probed yet).
For example, in a commonly available mobile SoC, registering just
one consumer device's driver at an initcall level earlier than the
supplier device's driver causes 11 failed probe attempts before the
consumer device probes successfully. This was with a kernel with all
the drivers statically compiled in. This problem gets a lot worse if
all the drivers are loaded as modules without direct symbol
dependencies.
- Supplier devices like clock providers, interconnect providers, etc
need to keep the resources they provide active and at a particular
state(s) during boot up even if their current set of consumers don't
request the resource to be active. This is because the rest of the
consumers might not have probed yet and turning off the resource
before all the consumers have probed could lead to a hang or
undesired user experience.
Some frameworks (Eg: regulator) handle this today by turning off
"unused" resources at late_initcall_sync and hoping all the devices
have probed by then. This is not a valid assumption for systems with
loadable modules. Other frameworks (Eg: clock) just don't handle
this due to the lack of a clear signal for when they can turn off
resources. This leads to downstream hacks to handle cases like this
that can easily be solved in the upstream kernel.
By linking devices before they are probed, we give suppliers a clear
count of the number of dependent consumers. Once all of the
consumers are active, the suppliers can turn off the unused
resources without making assumptions about the number of consumers.
By default we just add device-links to track "driver presence" (probe
succeeded) of the supplier device. If any other functionality provided
by device-links are needed, it is left to the consumer/supplier
devices to change the link when they probe.
v1 -> v2:
- Drop patch to speed up of_find_device_by_node()
- Drop depends-on property and use existing bindings
v2 -> v3:
- Refactor the code to have driver core initiate the linking of devs
- Have driver core link consumers to supplier before it's probed
- Add support for drivers to edit the device links before probing
v3 -> v4
- Tested edit_links() on system with cyclic dependency. Works.
- Added some checks to make sure device link isn't attempted from
parent device node to child device node.
- Added way to pause/resume sync_state callbacks across
of_platform_populate().
- Recursively parse DT node to create device links from parent to
suppliers of parent and all child nodes.
-Saravana
Saravana Kannan (8):
driver core: Add support for linking devices during device addition
of/platform: Add functional dependency link from DT bindings
driver core: Add sync_state driver/bus callback
driver core: Add edit_links() callback for drivers
driver core: Add APIs to pause/resume sync state callbacks
of/platform: Pause/resume sync state in of_platform_populate()
of/platform: Sanity check DT bindings before creating device links
of/platform: Create device links for all child-supplier depencencies
.../admin-guide/kernel-parameters.txt | 5 +
drivers/base/core.c | 162 ++++++++++++++++++
drivers/base/dd.c | 29 ++++
drivers/of/platform.c | 101 +++++++++++
include/linux/device.h | 47 +++++
5 files changed, 344 insertions(+)
--
2.22.0.410.gd8fdbe21b5-goog
next reply other threads:[~2019-07-08 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 22:56 Saravana Kannan [this message]
2019-07-08 22:56 ` [PATCH v4 1/8] driver core: Add support for linking devices during device addition Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 2/8] of/platform: Add functional dependency link from DT bindings Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 3/8] driver core: Add sync_state driver/bus callback Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 4/8] driver core: Add edit_links() callback for drivers Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 5/8] driver core: Add APIs to pause/resume sync state callbacks Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 6/8] of/platform: Pause/resume sync state in of_platform_populate() Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 7/8] of/platform: Sanity check DT bindings before creating device links Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 8/8] of/platform: Create device links for all child-supplier depencencies Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708225624.119973-1-saravanak@google.com \
--to=saravanak@google.com \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).