From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Poimboeuf Subject: Re: [PATCH v7 08/18] objtool: add kunit_try_catch_throw to the noreturn list Date: Tue, 9 Jul 2019 21:31:23 -0500 Message-ID: <20190710023123.ifnt5osimvzoe5hf@treble> References: <20190709063023.251446-1-brendanhiggins@google.com> <20190709063023.251446-9-brendanhiggins@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190709063023.251446-9-brendanhiggins@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Brendan Higgins Cc: frowand.list@gmail.com, gregkh@linuxfoundation.org, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, peterz@infradead.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim.Bird@sony.com, amir73il@gmail.com, dan.carpenter@oracle.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, mpe@ellerman. List-Id: devicetree@vger.kernel.org On Mon, Jul 08, 2019 at 11:30:13PM -0700, Brendan Higgins wrote: > Fix the following warning seen on GCC 7.3: > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() > > kunit_try_catch_throw is a function added in the following patch in this > series; it allows KUnit, a unit testing framework for the kernel, to > bail out of a broken test. As a consequence, it is a new __noreturn > function that objtool thinks is broken (as seen above). So fix this > warning by adding kunit_try_catch_throw to objtool's noreturn list. > > Reported-by: kbuild test robot > Signed-off-by: Brendan Higgins > Link: https://www.spinics.net/lists/linux-kbuild/msg21708.html > Cc: Josh Poimboeuf > Cc: Peter Zijlstra > --- > tools/objtool/check.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c > index 172f991957269..98db5fe85c797 100644 > --- a/tools/objtool/check.c > +++ b/tools/objtool/check.c > @@ -134,6 +134,7 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func, > "usercopy_abort", > "machine_real_restart", > "rewind_stack_do_exit", > + "kunit_try_catch_throw", > }; > > if (func->bind == STB_WEAK) > -- > 2.22.0.410.gd8fdbe21b5-goog > Acked-by: Josh Poimboeuf -- Josh