From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v3 04/14] dt-bindings: mailbox: qcom: Add clock-name optional property Date: Thu, 11 Jul 2019 07:45:57 -0700 Message-ID: <20190711144557.GE7234@tuxbook-pro> References: <20190625164733.11091-1-jorge.ramirez-ortiz@linaro.org> <20190625164733.11091-5-jorge.ramirez-ortiz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190625164733.11091-5-jorge.ramirez-ortiz@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Jorge Ramirez-Ortiz Cc: sboyd@kernel.org, david.brown@linaro.org, jassisinghbrar@gmail.com, mark.rutland@arm.com, mturquette@baylibre.com, robh+dt@kernel.org, will.deacon@arm.com, arnd@arndb.de, horms+renesas@verge.net.au, heiko@sntech.de, sibis@codeaurora.org, enric.balletbo@collabora.com, jagan@amarulasolutions.com, olof@lixom.net, vkoul@kernel.org, niklas.cassel@linaro.org, georgi.djakov@linaro.org, amit.kucheria@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, khasim.mohammed@linaro.org List-Id: devicetree@vger.kernel.org On Tue 25 Jun 09:47 PDT 2019, Jorge Ramirez-Ortiz wrote: > When the APCS clock is registered (platform dependent), it retrieves > its parent names from hardcoded values in the driver. > > The following commit allows the DT node to provide such clock names to > the platform data based clock driver therefore avoiding having to > explicitly embed those names in the clock driver source code. > > Co-developed-by: Niklas Cassel > Signed-off-by: Niklas Cassel > Signed-off-by: Jorge Ramirez-Ortiz > Reviewed-by: Rob Herring Reviewed-by: Bjorn Andersson > --- > .../mailbox/qcom,apcs-kpss-global.txt | 24 ++++++++++++++++--- > 1 file changed, 21 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt > index 1232fc9fc709..b69310322b09 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt > @@ -18,10 +18,11 @@ platforms. > Usage: required > Value type: > Definition: must specify the base address and size of the global block > + > - clocks: > - Usage: required if #clocks-cells property is present > - Value type: > - Definition: phandle to the input PLL, which feeds the APCS mux/divider > + Usage: required if #clock-names property is present > + Value type: > + Definition: phandles to the two parent clocks of the clock driver. > > - #mbox-cells: > Usage: required > @@ -33,6 +34,12 @@ platforms. > Value type: > Definition: as described in clock.txt, must be 0 > > +- clock-names: > + Usage: required if the platform data based clock driver needs to > + retrieve the parent clock names from device tree. > + This will requires two mandatory clocks to be defined. > + Value type: > + Definition: must be "aux" and "pll" > > = EXAMPLE > The following example describes the APCS HMSS found in MSM8996 and part of the > @@ -65,3 +72,14 @@ Below is another example of the APCS binding on MSM8916 platforms: > clocks = <&a53pll>; > #clock-cells = <0>; > }; > + > +Below is another example of the APCS binding on QCS404 platforms: > + > + apcs_glb: mailbox@b011000 { > + compatible = "qcom,qcs404-apcs-apps-global", "syscon"; > + reg = <0x0b011000 0x1000>; > + #mbox-cells = <1>; > + clocks = <&gcc GCC_GPLL0_AO_OUT_MAIN>, <&apcs_hfpll>; > + clock-names = "aux", "pll"; > + #clock-cells = <0>; > + }; > -- > 2.21.0 >