From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Biwen Li <biwen.li@nxp.com>
Cc: a.zummo@towertech.it, leoyang.li@nxp.com, robh+dt@kernel.org,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
xiaobo.xie@nxp.com, jiafei.pan@nxp.com, ran.wang_1@nxp.com,
mark.rutland@arm.com, devicetree@vger.kernel.org
Subject: Re: [v4,1/2] rtc/fsl: add FTM alarm driver as the wakeup source
Date: Mon, 15 Jul 2019 16:56:37 +0200 [thread overview]
Message-ID: <20190715145637.GG4732@piout.net> (raw)
In-Reply-To: <20190715101520.22562-1-biwen.li@nxp.com>
On 15/07/2019 18:15:19+0800, Biwen Li wrote:
> + device_init_wakeup(&pdev->dev, true);
> + rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, "ftm-alarm",
> + &ftm_rtc_ops,
> + THIS_MODULE);
To be clear, I want you to not use devm_rtc_device_register and use
devm_rtc_allocate_device and rtc_register_device.
> + if (IS_ERR(rtc->rtc_dev)) {
> + dev_err(&pdev->dev, "can't register rtc device\n");
> + return PTR_ERR(rtc->rtc_dev);
> + }
> +
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-07-15 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 10:15 [v4,1/2] rtc/fsl: add FTM alarm driver as the wakeup source Biwen Li
2019-07-15 10:15 ` [v4,2/2] Documentation: dt: binding: rtc: add binding for ftm alarm driver Biwen Li
2019-07-15 14:56 ` Alexandre Belloni [this message]
2019-07-16 3:49 ` [EXT] Re: [v4,1/2] rtc/fsl: add FTM alarm driver as the wakeup source Biwen Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715145637.GG4732@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=biwen.li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=jiafei.pan@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ran.wang_1@nxp.com \
--cc=robh+dt@kernel.org \
--cc=xiaobo.xie@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).