From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Nick Dyer <nick@shmanahar.org>, Rob Herring <robh+dt@kernel.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
kernel@pengutronix.de, patchwork-lst@pengutronix.de,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH] Input: atmel_mxt_ts - allow specification of config name
Date: Wed, 17 Jul 2019 06:33:46 +0300 [thread overview]
Message-ID: <20190717033346.GA621@penguin> (raw)
In-Reply-To: <20190712135338.6211-1-l.stach@pengutronix.de>
Hi Lucas,
On Fri, Jul 12, 2019 at 03:53:38PM +0200, Lucas Stach wrote:
> From: Nick Dyer <nick@shmanahar.org>
>
> Some systems require different touchscreen configurations depending on the
> populated touchscreen. To allow different configs to co-exist in the file
> system we need a way to tell the driver, which config should be loaded.
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> lst:
> - switch to property name to not use underscore
> - Add more elaborate commit message
I believe we have already discussed this patch and back then I said that
the "atmel" prefix was not appropriate, as it describes not hardware
specifics but rather Linux kernel behavior and therefore we should be
using "linux,cfg-name" as the property. Unfortunately that version of
the patch got lost in my mailbox.
I will fish it out and apply.
Thanks.
--
Dmitry
prev parent reply other threads:[~2019-07-17 3:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 13:53 [PATCH] Input: atmel_mxt_ts - allow specification of config name Lucas Stach
2019-07-17 3:33 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717033346.GA621@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=nick@shmanahar.org \
--cc=patchwork-lst@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).