From: Shawn Guo <shawnguo@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: leoyang.li@nxp.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: add the console node for DPAA2 platforms
Date: Mon, 22 Jul 2019 11:23:13 +0800 [thread overview]
Message-ID: <20190722032312.GV3738@dragon> (raw)
In-Reply-To: <1562080578-31677-1-git-send-email-ioana.ciornei@nxp.com>
On Tue, Jul 02, 2019 at 06:16:18PM +0300, Ioana Ciornei wrote:
> Add the console device tree node for the following
> DPAA2 based platforms: LS1088A, LS2080A, LS2088A and LX2160A.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Please copy linux-arm-kernel@lists.infradead.org as well.
> ---
> Changes in v2:
> - use a generic node name
> - remove leading zeros and 0x from the unit-address
>
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 +++++
> arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 5 +++++
> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 5 +++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 661137ffa319..d190d5490e31 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -665,6 +665,11 @@
> clock-names = "apb_pclk", "wdog_clk";
> };
>
> + console@8340020 {
Please sort node in unit-address. Hint: it should be added right before
node ptp-timer@8b95000.
Shawn
> + compatible = "fsl,dpaa2-console";
> + reg = <0x00000000 0x08340020 0 0x2>;
> + };
> +
> fsl_mc: fsl-mc@80c000000 {
> compatible = "fsl,qoriq-mc";
> reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> index d7e78dcd153d..229d7f7d293d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> @@ -321,6 +321,11 @@
> };
> };
>
> + console@8340020 {
> + compatible = "fsl,dpaa2-console";
> + reg = <0x00000000 0x08340020 0 0x2>;
> + };
> +
> fsl_mc: fsl-mc@80c000000 {
> compatible = "fsl,qoriq-mc";
> reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 125a8cc2c5b3..0426e2230447 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -848,6 +848,11 @@
> dma-coherent;
> };
>
> + console@8340020 {
> + compatible = "fsl,dpaa2-console";
> + reg = <0x00000000 0x08340020 0 0x2>;
> + };
> +
> fsl_mc: fsl-mc@80c000000 {
> compatible = "fsl,qoriq-mc";
> reg = <0x00000008 0x0c000000 0 0x40>,
> --
> 1.9.1
>
prev parent reply other threads:[~2019-07-22 3:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 15:16 [PATCH v2] arm64: dts: add the console node for DPAA2 platforms Ioana Ciornei
2019-07-22 3:23 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722032312.GV3738@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=leoyang.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).