From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:34314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727840AbfGVDXh (ORCPT ); Sun, 21 Jul 2019 23:23:37 -0400 Date: Mon, 22 Jul 2019 11:23:13 +0800 From: Shawn Guo Subject: Re: [PATCH v2] arm64: dts: add the console node for DPAA2 platforms Message-ID: <20190722032312.GV3738@dragon> References: <1562080578-31677-1-git-send-email-ioana.ciornei@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1562080578-31677-1-git-send-email-ioana.ciornei@nxp.com> Sender: devicetree-owner@vger.kernel.org To: Ioana Ciornei Cc: leoyang.li@nxp.com, devicetree@vger.kernel.org List-ID: On Tue, Jul 02, 2019 at 06:16:18PM +0300, Ioana Ciornei wrote: > Add the console device tree node for the following > DPAA2 based platforms: LS1088A, LS2080A, LS2088A and LX2160A. > > Signed-off-by: Ioana Ciornei Please copy linux-arm-kernel@lists.infradead.org as well. > --- > Changes in v2: > - use a generic node name > - remove leading zeros and 0x from the unit-address > > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 +++++ > arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 5 +++++ > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 5 +++++ > 3 files changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index 661137ffa319..d190d5490e31 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -665,6 +665,11 @@ > clock-names = "apb_pclk", "wdog_clk"; > }; > > + console@8340020 { Please sort node in unit-address. Hint: it should be added right before node ptp-timer@8b95000. Shawn > + compatible = "fsl,dpaa2-console"; > + reg = <0x00000000 0x08340020 0 0x2>; > + }; > + > fsl_mc: fsl-mc@80c000000 { > compatible = "fsl,qoriq-mc"; > reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */ > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > index d7e78dcd153d..229d7f7d293d 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > @@ -321,6 +321,11 @@ > }; > }; > > + console@8340020 { > + compatible = "fsl,dpaa2-console"; > + reg = <0x00000000 0x08340020 0 0x2>; > + }; > + > fsl_mc: fsl-mc@80c000000 { > compatible = "fsl,qoriq-mc"; > reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */ > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index 125a8cc2c5b3..0426e2230447 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -848,6 +848,11 @@ > dma-coherent; > }; > > + console@8340020 { > + compatible = "fsl,dpaa2-console"; > + reg = <0x00000000 0x08340020 0 0x2>; > + }; > + > fsl_mc: fsl-mc@80c000000 { > compatible = "fsl,qoriq-mc"; > reg = <0x00000008 0x0c000000 0 0x40>, > -- > 1.9.1 >