From: Mark Brown <broonie@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: linux-iio@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
jic23@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [PATCH 1/4][V3] spi: Add optional stall delay between cs_change transfers
Date: Mon, 22 Jul 2019 17:32:02 +0100 [thread overview]
Message-ID: <20190722163202.GG4756@sirena.org.uk> (raw)
In-Reply-To: <20190722124747.4792-2-alexandru.ardelean@analog.com>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Mon, Jul 22, 2019 at 03:47:44PM +0300, Alexandru Ardelean wrote:
> Some devices like the ADIS16460 IMU require a longer period between
> transfers, i.e. between when the CS is de-asserted and re-asserted. The
> default value of 10us is not enough. This change makes the delay
> configurable for when the next CS change goes active, allowing the default
> to remain 10us is case it is unspecified.
For the third time:
| This looks like cs_change_delay.
> #define SPI_NBITS_QUAD 0x04 /* 4bits transfer */
> u8 bits_per_word;
> u8 word_delay_usecs;
> + u8 cs_change_delay;
> u16 delay_usecs;
> u32 speed_hz;
> u16 word_delay;
This patch doesn't apply and even if it did it won't compile because you
are trying to add a field with the same name as an existing one.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-22 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 12:47 [PATCH 0/4][V3] iio: imu: Add support for the ADIS16460 IMU Alexandru Ardelean
2019-07-22 12:47 ` [PATCH 1/4][V3] spi: Add optional stall delay between cs_change transfers Alexandru Ardelean
2019-07-22 16:32 ` Mark Brown [this message]
2019-07-22 19:27 ` Alexandru Ardelean
2019-07-22 12:47 ` [PATCH 2/4][V3] iio: imu: adis: Add support for SPI transfer cs_change_delay Alexandru Ardelean
2019-07-22 12:47 ` [PATCH 3/4][V3] iio: imu: Add support for the ADIS16460 IMU Alexandru Ardelean
2019-07-22 12:47 ` [PATCH 4/4][V3] dt-bindings: iio: imu: add bindings for ADIS16460 Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722163202.GG4756@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael.hennerich@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox