From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Chevallier Subject: Re: [PATCH v2 03/19] phy: mvebu-cp110-comphy: Add SMC call support Date: Tue, 23 Jul 2019 10:48:49 +0200 Message-ID: <20190723104849.7158f634@bootlin.com> References: <20190627095104.22529-1-miquel.raynal@bootlin.com> <20190627095104.22529-4-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190627095104.22529-4-miquel.raynal@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Miquel Raynal Cc: Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , Grzegorz Jaszczyk , Gregory Clement , Russell King , Kishon Vijay Abraham I , Nadav Haklai , Rob Herring , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org Hi Miquel, Thanks for this, I gave it a quick test and it looks good. On Thu, 27 Jun 2019 11:50:48 +0200 Miquel Raynal wrote: >From: Grzegorz Jaszczyk > >Keep the exact same list of supported configurations but first try to >use the firmware's implementation. If it fails, try the legacy method: >Linux implementation. > >Signed-off-by: Grzegorz Jaszczyk >[miquel.raynal@bootlin.com: adapt the content to the mainline driver] >Signed-off-by: Miquel Raynal [...] >+ dev_warn(priv->dev, >+ "Firmware could not configure PHY %d with mode %d (ret: %d), trying legacy method\n", >+ ret, lane->id, lane->mode); Small nit, you've got your parameters in the wrong order in that dev_warn. Besides that, Tested-by: Maxime Chevallier