* [PATCH 1/2] ARM: dts: rockchip: Cleanup style around assignment operator
@ 2019-07-27 14:27 Krzysztof Kozlowski
2019-07-27 14:27 ` [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron Krzysztof Kozlowski
2019-07-27 15:38 ` [PATCH 1/2] ARM: dts: rockchip: Cleanup style around assignment operator Heiko Stuebner
0 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2019-07-27 14:27 UTC (permalink / raw)
To: Heiko Stuebner, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Use a space before and after assignment operator to have consistent
style.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm/boot/dts/rk3036.dtsi | 2 +-
arch/arm/boot/dts/rk3288-evb.dtsi | 2 +-
arch/arm/boot/dts/rk3288-tinker.dtsi | 12 ++++++------
arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 2 +-
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi
index 0290ea4edd32..c776321b2cc4 100644
--- a/arch/arm/boot/dts/rk3036.dtsi
+++ b/arch/arm/boot/dts/rk3036.dtsi
@@ -484,7 +484,7 @@
compatible = "rockchip,rockchip-spi";
reg = <0x20074000 0x1000>;
interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
- clocks =<&cru PCLK_SPI>, <&cru SCLK_SPI>;
+ clocks = <&cru PCLK_SPI>, <&cru SCLK_SPI>;
clock-names = "apb-pclk","spi_pclk";
dmas = <&pdma 8>, <&pdma 9>;
dma-names = "tx", "rx";
diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
index 820440715302..2afd686b2033 100644
--- a/arch/arm/boot/dts/rk3288-evb.dtsi
+++ b/arch/arm/boot/dts/rk3288-evb.dtsi
@@ -97,7 +97,7 @@
};
panel: panel {
- compatible ="lg,lp079qx1-sp0v", "simple-panel";
+ compatible = "lg,lp079qx1-sp0v", "simple-panel";
backlight = <&backlight>;
enable-gpios = <&gpio7 RK_PA4 GPIO_ACTIVE_HIGH>;
pinctrl-0 = <&lcd_cs>;
diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi
index 293576869546..81e4e953d4a4 100644
--- a/arch/arm/boot/dts/rk3288-tinker.dtsi
+++ b/arch/arm/boot/dts/rk3288-tinker.dtsi
@@ -47,13 +47,13 @@
compatible = "gpio-leds";
act-led {
- gpios=<&gpio1 RK_PD0 GPIO_ACTIVE_HIGH>;
- linux,default-trigger="mmc0";
+ gpios = <&gpio1 RK_PD0 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "mmc0";
};
heartbeat-led {
- gpios=<&gpio1 RK_PD1 GPIO_ACTIVE_HIGH>;
- linux,default-trigger="heartbeat";
+ gpios = <&gpio1 RK_PD1 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
};
pwr-led {
@@ -443,7 +443,7 @@
&saradc {
vref-supply = <&vcc18_ldo1>;
- status ="okay";
+ status = "okay";
};
&sdmmc {
@@ -516,7 +516,7 @@
};
&usb_otg {
- status= "okay";
+ status = "okay";
};
&vopb {
diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
index 1cadb522fd0d..e0183655e92c 100644
--- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
@@ -86,7 +86,7 @@
};
panel: panel {
- compatible ="innolux,n116bge", "simple-panel";
+ compatible = "innolux,n116bge", "simple-panel";
status = "okay";
power-supply = <&vcc33_lcd>;
backlight = <&backlight>;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron
2019-07-27 14:27 [PATCH 1/2] ARM: dts: rockchip: Cleanup style around assignment operator Krzysztof Kozlowski
@ 2019-07-27 14:27 ` Krzysztof Kozlowski
2019-07-27 15:33 ` Heiko Stuebner
2019-07-27 15:38 ` [PATCH 1/2] ARM: dts: rockchip: Cleanup style around assignment operator Heiko Stuebner
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2019-07-27 14:27 UTC (permalink / raw)
To: Heiko Stuebner, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Fix DTC warning:
arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4:
Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm/boot/dts/rk3288-veyron.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
index 8fc8eac699bf..02243ff46a65 100644
--- a/arch/arm/boot/dts/rk3288-veyron.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
@@ -18,7 +18,7 @@
* The default coreboot on veyron devices ignores memory@0 nodes
* and would instead create another memory node.
*/
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x0 0x0 0x0 0x80000000>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron
2019-07-27 14:27 ` [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron Krzysztof Kozlowski
@ 2019-07-27 15:33 ` Heiko Stuebner
2019-07-28 11:38 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2019-07-27 15:33 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
Hi Krzysztof,
Am Samstag, 27. Juli 2019, 16:27:36 CEST schrieb Krzysztof Kozlowski:
> Fix DTC warning:
>
> arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4:
> Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
please see the comment directly above the memory node on why that needs
to stay that way. So no, we'll keep the veyron memory node as is.
Heiko
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm/boot/dts/rk3288-veyron.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> index 8fc8eac699bf..02243ff46a65 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -18,7 +18,7 @@
> * The default coreboot on veyron devices ignores memory@0 nodes
> * and would instead create another memory node.
> */
> - memory {
> + memory@0 {
> device_type = "memory";
> reg = <0x0 0x0 0x0 0x80000000>;
> };
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron
2019-07-27 15:33 ` Heiko Stuebner
@ 2019-07-28 11:38 ` Krzysztof Kozlowski
2019-07-28 20:55 ` Heiko Stuebner
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2019-07-28 11:38 UTC (permalink / raw)
To: Heiko Stuebner; +Cc: linux-rockchip, linux-kernel, linux-arm-kernel, devicetree
On Sat, 27 Jul 2019 at 17:33, Heiko Stuebner <heiko@sntech.de> wrote:
>
> Hi Krzysztof,
>
> Am Samstag, 27. Juli 2019, 16:27:36 CEST schrieb Krzysztof Kozlowski:
> > Fix DTC warning:
> >
> > arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4:
> > Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
>
> please see the comment directly above the memory node on why that needs
> to stay that way. So no, we'll keep the veyron memory node as is.
Damn it, I missed it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron
2019-07-28 11:38 ` Krzysztof Kozlowski
@ 2019-07-28 20:55 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2019-07-28 20:55 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
Am Sonntag, 28. Juli 2019, 13:38:43 CEST schrieb Krzysztof Kozlowski:
> On Sat, 27 Jul 2019 at 17:33, Heiko Stuebner <heiko@sntech.de> wrote:
> >
> > Hi Krzysztof,
> >
> > Am Samstag, 27. Juli 2019, 16:27:36 CEST schrieb Krzysztof Kozlowski:
> > > Fix DTC warning:
> > >
> > > arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4:
> > > Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
> >
> > please see the comment directly above the memory node on why that needs
> > to stay that way. So no, we'll keep the veyron memory node as is.
>
> Damn it, I missed it.
no worries :-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: rockchip: Cleanup style around assignment operator
2019-07-27 14:27 [PATCH 1/2] ARM: dts: rockchip: Cleanup style around assignment operator Krzysztof Kozlowski
2019-07-27 14:27 ` [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron Krzysztof Kozlowski
@ 2019-07-27 15:38 ` Heiko Stuebner
1 sibling, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2019-07-27 15:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
Am Samstag, 27. Juli 2019, 16:27:35 CEST schrieb Krzysztof Kozlowski:
> Use a space before and after assignment operator to have consistent
> style.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
I've adapted the patch around recent chromebook display changes
(regarding veyron-chromebook.dtsi) and applied the result for 5.4
Thanks
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-28 20:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-27 14:27 [PATCH 1/2] ARM: dts: rockchip: Cleanup style around assignment operator Krzysztof Kozlowski
2019-07-27 14:27 ` [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron Krzysztof Kozlowski
2019-07-27 15:33 ` Heiko Stuebner
2019-07-28 11:38 ` Krzysztof Kozlowski
2019-07-28 20:55 ` Heiko Stuebner
2019-07-27 15:38 ` [PATCH 1/2] ARM: dts: rockchip: Cleanup style around assignment operator Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).