From: "Guido Günther" <agx@sigxcpu.org>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Anson Huang <Anson.Huang@nxp.com>,
Mark Rutland <mark.rutland@arm.com>,
Carlo Caione <ccaione@baylibre.com>,
"Angus Ainslie (Purism)" <angus@akkea.ca>,
Leonard Crestez <leonard.crestez@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
linux-clk@vger.kernel.org, Abel Vesa <abel.vesa@nxp.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
daniel.lezcano@linaro.org, dl-linux-imx <Linux-imx@nxp.com>,
rui.zhang@intel.com, Michael Turquette <mturquette@baylibre.com>,
Devicetree List <devicetree@vger.kernel.org>,
linux-pm@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
edubezval@gmail.com, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Stephen Boyd <sboyd@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT
Date: Sat, 27 Jul 2019 20:26:36 +0200 [thread overview]
Message-ID: <20190727182636.GA7170@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <CAEnQRZAZNMBx3ApVmRP8hYPw0XY_QgR-saE6WLcT8oZmHPCxSA@mail.gmail.com>
Hi Daniel,
On Sat, Jul 27, 2019 at 01:26:50AM +0300, Daniel Baluta wrote:
> Hi all,
>
> latest linux-next hangs at boot.
>
> commit fde50b96be821ac9673a7e00847cc4605bd88f34 (HEAD -> master, tag:
> next-20190726, origin/master, origin/HEAD)
> Author: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri Jul 26 15:18:02 2019 +1000
>
> Add linux-next specific files for 20190726
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
>
> I know this is crazy but reverting commit:
>
> commit 431bdd1df48ee2896ea9980d9153e3aeaf0c81ef (refs/bisect/bad)
> Author: Anson Huang <Anson.Huang@nxp.com>
> Date: Fri Jul 5 12:56:11 2019 +0800
>
> clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT
>
> IMX8MQ_CLK_TMU_ROOT is ONLY used for thermal module, the driver
> should manage this clock, so no need to have CLK_IS_CRITICAL flag
> set.
>
>
>
> makes the boot work again.
I noticed a boot hang yesterday on next-20190726 when loading the
qoriq_thermal which I worked around by blacklisting it. The
fsl,imx8mq-tmu node specifies a clock (IMX8MQ_CLK_TMU_ROOT) but does not
seem to enable, shouldn't it do so?
Cheers,
-- Guido
next prev parent reply other threads:[~2019-07-27 18:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 4:56 [PATCH 1/6] thermal: qoriq: Use devm_platform_ioremap_resource() instead of of_iomap() Anson.Huang
2019-07-05 4:56 ` [PATCH 2/6] thermal: qoriq: Use __maybe_unused instead of #if CONFIG_PM_SLEEP Anson.Huang
2019-07-05 4:56 ` [PATCH 3/6] dt-bindings: thermal: qoriq: Add optional clocks property Anson.Huang
2019-07-22 23:55 ` Rob Herring
2019-07-05 4:56 ` [PATCH 4/6] thermal: qoriq: Add clock operations Anson.Huang
2019-07-29 8:12 ` Guido Günther
2019-07-29 8:40 ` Anson Huang
2019-07-05 4:56 ` [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT Anson.Huang
2019-07-05 7:01 ` Abel Vesa
2019-07-22 21:31 ` Stephen Boyd
2019-07-23 2:50 ` Shawn Guo
2019-07-26 22:26 ` Daniel Baluta
2019-07-27 6:19 ` Anson Huang
2019-07-27 6:33 ` Daniel Baluta
2019-07-27 16:17 ` Abel Vesa
2019-07-29 1:29 ` Anson Huang
2019-07-29 6:51 ` Daniel Baluta
2019-07-29 7:14 ` Anson Huang
2019-07-29 7:20 ` Daniel Baluta
2019-07-29 7:21 ` Daniel Baluta
2019-07-29 7:49 ` Anson Huang
2019-07-29 8:13 ` Daniel Baluta
2019-07-27 18:26 ` Guido Günther [this message]
2019-07-27 20:17 ` Fabio Estevam
2019-07-28 7:58 ` Guido Günther
2019-07-28 15:24 ` Fabio Estevam
2019-07-05 4:56 ` [PATCH 6/6] arm64: dts: imx8mq: Add clock for TMU node Anson.Huang
2019-07-23 2:51 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190727182636.GA7170@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=angus@akkea.ca \
--cc=ccaione@baylibre.com \
--cc=daniel.baluta@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=festevam@gmail.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).