From: Boris Brezillon <boris.brezillon@collabora.com>
To: masonccyang@mxic.com.tw
Cc: anders.roxell@linaro.org, bbrezillon@kernel.org,
christophe.kerello@st.com, computersforpeace@gmail.com,
devicetree@vger.kernel.org, dwmw2@infradead.org,
juliensu@mxic.com.tw, lee.jones@linaro.org,
liang.yang@amlogic.com, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, marek.vasut@gmail.com,
mark.rutland@arm.com, miquel.raynal@bootlin.com,
paul@crapouillou.net, paul.burton@mips.com, richard@nod.at,
robh+dt@kernel.org, stefan@agner.ch, vigneshr@ti.com
Subject: Re: [PATCH v6 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings
Date: Thu, 1 Aug 2019 11:23:43 +0200 [thread overview]
Message-ID: <20190801112343.0b770da0@collabora.com> (raw)
In-Reply-To: <OF42C4D3EC.9549E8DC-ON48258449.003273A5-48258449.00330A06@mxic.com.tw>
On Thu, 1 Aug 2019 17:17:29 +0800
masonccyang@mxic.com.tw wrote:
> Hi Boris,
>
> > On Thu, 1 Aug 2019 11:55:10 +0800
> > Mason Yang <masonccyang@mxic.com.tw> wrote:
> >
> > > Document the bindings used by the Macronix raw NAND controller.
> > >
> > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> > > ---
> > > Documentation/devicetree/bindings/mtd/mxic-nand.txt | 19
> +++++++++++++++++++
> > > 1 file changed, 19 insertions(+)
> > > create mode 100644
> Documentation/devicetree/bindings/mtd/mxic-nand.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mtd/mxic-nand.txt b/
> > Documentation/devicetree/bindings/mtd/mxic-nand.txt
> > > new file mode 100644
> > > index 0000000..de37d60
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mtd/mxic-nand.txt
> > > @@ -0,0 +1,19 @@
> > > +Macronix Raw NAND Controller Device Tree Bindings
> > > +-------------------------------------------------
> > > +
> > > +Required properties:
> > > +- compatible: should be "mxicy,multi-itfc-v009-nand-morph"
> > > +- reg: should contain 1 entry for the registers
> > > +- interrupts: interrupt line connected to this raw NAND controller
> > > +- clock-names: should contain "ps", "send" and "send_dly"
> > > +- clocks: should contain 3 phandles for the "ps", "send" and
> > > + "send_dly" clocks
> > > +
> > > +Example:
> > > +
> > > + nand: nand-controller@43c30000 {
> > > + compatible = "mxicy,multi-itfc-v009-nand-morph";
> > > + reg = <0x43c30000 0x10000>;
> > > + clocks = <&clkwizard 0>, <&clkwizard 1>, <&clkc 15>;
> > > + clock-names = "send", "send_dly", "ps";
> >
> > You should have subnodes describing the NAND connected to the
> > controller (see [1]).
> >
> > [1]
> https://elixir.bootlin.com/linux/v5.3-rc2/source/Documentation/devicetree/
> > bindings/mtd/nand-controller.yaml#L131
> >
> > > + };
> >
>
> Do you mean to add patternProperties ?
>
> nand: nand-controller@43c30000 {
> compatible =
> "mxicy,multi-itfc-v009-nand-morph";
> reg = <0x43c30000 0x10000>;
> clocks = <&clkwizard 0>, <&clkwizard 1>,
> <&clkc 15>;
> clock-names = "send", "send_dly", "ps";
>
#address-cells = <1>;
#size-cells = <0>;
> + nand@0 {
> +
reg = <0>;
/* nand props here */
> + };
> };
>
> something like that.
Yes, something like that.
next prev parent reply other threads:[~2019-08-01 9:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 3:55 [PATCH v6 0/2] Add Macronix raw NAND controller driver Mason Yang
2019-08-01 3:55 ` [PATCH v6 1/2] mtd: rawnand: " Mason Yang
2019-08-01 6:22 ` Boris Brezillon
2019-08-05 9:21 ` masonccyang
2019-08-16 10:10 ` masonccyang
2019-08-01 3:55 ` [PATCH v6 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings Mason Yang
2019-08-01 5:57 ` Boris Brezillon
2019-08-01 9:17 ` masonccyang
2019-08-01 9:23 ` Boris Brezillon [this message]
2019-08-01 7:13 ` Miquel Raynal
2019-08-01 9:32 ` masonccyang
2019-08-01 9:36 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801112343.0b770da0@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=anders.roxell@linaro.org \
--cc=bbrezillon@kernel.org \
--cc=christophe.kerello@st.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=juliensu@mxic.com.tw \
--cc=lee.jones@linaro.org \
--cc=liang.yang@amlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).