From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v3 05/10] rtc: mt6397: add compatible for mt6323 Date: Mon, 5 Aug 2019 15:50:44 +0200 Message-ID: <20190805135044.GH3600@piout.net> References: <20190729174154.4335-1-frank-w@public-files.de> <20190729174154.4335-6-frank-w@public-files.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190729174154.4335-6-frank-w@public-files.de> Sender: linux-kernel-owner@vger.kernel.org To: Frank Wunderlich Cc: Alessandro Zummo , Allison Randal , "David S. Miller" , devicetree@vger.kernel.org, Eddie Huang , Greg Kroah-Hartman , Jonathan Cameron , Kate Stewart , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, Mark Rutland , Matthias Brugger , Mauro Carvalho Chehab , Nicolas Ferre , Richard Fontana , Rob Herring List-Id: devicetree@vger.kernel.org On 29/07/2019 19:41:49+0200, Frank Wunderlich wrote: > From: Josef Friedl > > use mt6397 rtc driver also for mt6323 > compatible needed because of different rtc-base/size see part 7 I still don't think this is a good reason so I would remove that sentence. Also, it refers to part 7 which is an info that will not be available when looking at the git history. > > changes since v2: splitted this from v2.3 suggested-by Alexandre Belloni > Changelog after the --- marker please. > Signed-off-by: Josef Friedl > Signed-off-by: Frank Wunderlich > --- > drivers/rtc/rtc-mt6397.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > index 9370b7fc9f81..21cd9cc8b4c7 100644 > --- a/drivers/rtc/rtc-mt6397.c > +++ b/drivers/rtc/rtc-mt6397.c > @@ -325,6 +325,7 @@ static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, mt6397_rtc_suspend, > mt6397_rtc_resume); > > static const struct of_device_id mt6397_rtc_of_match[] = { > + { .compatible = "mediatek,mt6323-rtc", }, > { .compatible = "mediatek,mt6397-rtc", }, > { } > }; > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com