* [PATCH] of/platform: Clean up a return type in of_link_property()
@ 2019-08-08 10:32 Dan Carpenter
2019-08-08 16:09 ` Frank Rowand
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-08-08 10:32 UTC (permalink / raw)
To: Rob Herring, Saravana Kannan
Cc: Frank Rowand, Anton Vorontsov, Colin Cross, Tony Luck, devicetree,
kernel-janitors
This function is supposed to return zero on success and negative
error codes on failure but currently it returns true on failure. The
caller only checks for zero and non-zero so this mixup doesn't cause any
runtime issues.
Fixes: 690ff7881b26 ("of/platform: Add functional dependency link from DT bindings")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/of/platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 21838226d68a..86fb8ab8c012 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -625,7 +625,7 @@ static const struct supplier_bindings bindings[] = {
{ },
};
-static bool of_link_property(struct device *dev, struct device_node *con_np,
+static int of_link_property(struct device *dev, struct device_node *con_np,
const char *prop)
{
struct device_node *phandle;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] of/platform: Clean up a return type in of_link_property()
2019-08-08 10:32 [PATCH] of/platform: Clean up a return type in of_link_property() Dan Carpenter
@ 2019-08-08 16:09 ` Frank Rowand
0 siblings, 0 replies; 2+ messages in thread
From: Frank Rowand @ 2019-08-08 16:09 UTC (permalink / raw)
To: Dan Carpenter, Rob Herring, Saravana Kannan
Cc: Anton Vorontsov, Colin Cross, Tony Luck, devicetree,
kernel-janitors
On 8/8/19 3:32 AM, Dan Carpenter wrote:
> This function is supposed to return zero on success and negative
> error codes on failure but currently it returns true on failure. The
> caller only checks for zero and non-zero so this mixup doesn't cause any
> runtime issues.
>
> Fixes: 690ff7881b26 ("of/platform: Add functional dependency link from DT bindings")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/of/platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index 21838226d68a..86fb8ab8c012 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -625,7 +625,7 @@ static const struct supplier_bindings bindings[] = {
> { },
> };
>
> -static bool of_link_property(struct device *dev, struct device_node *con_np,
> +static int of_link_property(struct device *dev, struct device_node *con_np,
> const char *prop)
> {
> struct device_node *phandle;
>
Hi Dan,
Thanks for catching this.
Another patch was submitted to fix this just before your patch.
-Frank
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-08 16:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-08 10:32 [PATCH] of/platform: Clean up a return type in of_link_property() Dan Carpenter
2019-08-08 16:09 ` Frank Rowand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).