From: Boris Brezillon <boris.brezillon@collabora.com>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
vigneshr@ti.com, bbrezillon@kernel.org, avifishman70@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] spi: npcm-fiu: add NPCM FIU controller driver
Date: Thu, 8 Aug 2019 17:32:32 +0200 [thread overview]
Message-ID: <20190808173232.4d79d698@collabora.com> (raw)
In-Reply-To: <20190808131448.349161-3-tmaimon77@gmail.com>
On Thu, 8 Aug 2019 16:14:48 +0300
Tomer Maimon <tmaimon77@gmail.com> wrote:
> +
> +static const struct spi_controller_mem_ops npcm_fiu_mem_ops = {
> + .exec_op = npcm_fiu_exec_op,
No npcm_supports_op()? That's suspicious, especially after looking at
the npcm_fiu_exec_op() (and the functions called from there) where the
requested ->buswidth seems to be completely ignored...
> + .dirmap_create = npcm_fiu_dirmap_create,
> + .dirmap_read = npcm_fiu_direct_read,
> + .dirmap_write = npcm_fiu_direct_write,
> +};
> +
next prev parent reply other threads:[~2019-08-08 15:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 13:14 [PATCH v2 0/2] spi: add NPCM FIU controller driver Tomer Maimon
2019-08-08 13:14 ` [PATCH v2 1/2] dt-binding: spi: add NPCM FIU controller Tomer Maimon
2019-08-21 20:56 ` Rob Herring
2019-08-08 13:14 ` [PATCH v2 2/2] spi: npcm-fiu: add NPCM FIU controller driver Tomer Maimon
2019-08-08 13:27 ` Mark Brown
2019-08-08 15:37 ` Tomer Maimon
2019-08-08 18:55 ` Mark Brown
2019-08-09 15:31 ` Tomer Maimon
2019-08-08 15:32 ` Boris Brezillon [this message]
2019-08-09 15:26 ` Tomer Maimon
2019-08-09 15:25 ` Boris Brezillon
2019-08-09 15:47 ` Tomer Maimon
2019-08-09 15:51 ` Boris Brezillon
2019-08-09 16:19 ` Tomer Maimon
2019-08-09 18:01 ` Benjamin Fair
2019-08-09 22:23 ` Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808173232.4d79d698@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=avifishman70@gmail.com \
--cc=bbrezillon@kernel.org \
--cc=benjaminfair@google.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=vigneshr@ti.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).